Code refactor

Signed-off-by: Sam Poyigi <[email protected]>
tastyigniter · Jul 12, 2024 · 8116f55 · 8116f55
1 parent 6ddd2e1
commit 8116f55
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -35,6 +35,36 @@ parameters:
 			count: 1
 			path: src/CartConditions/Coupon.php
 
+		-
+			message: "#^Access to an undefined property Illuminate\\\\Support\\\\Optional\\:\\:\\$discount\\.$#"
+			count: 2
+			path: src/CartConditions/Coupon.php
+
+		-
+			message: "#^Access to an undefined property Illuminate\\\\Support\\\\Optional\\:\\:\\$group\\.$#"
+			count: 1
+			path: src/CartConditions/Coupon.php
+
+		-
+			message: "#^Call to an undefined method Illuminate\\\\Support\\\\Optional\\:\\:appliesOnDelivery\\(\\)\\.$#"
+			count: 1
+			path: src/CartConditions/Coupon.php
+
+		-
+			message: "#^Call to an undefined method Illuminate\\\\Support\\\\Optional\\:\\:appliesOnMenuItems\\(\\)\\.$#"
+			count: 1
+			path: src/CartConditions/Coupon.php
+
+		-
+			message: "#^Call to an undefined method Illuminate\\\\Support\\\\Optional\\:\\:discountWithOperand\\(\\)\\.$#"
+			count: 1
+			path: src/CartConditions/Coupon.php
+
+		-
+			message: "#^Call to an undefined method Illuminate\\\\Support\\\\Optional\\:\\:isFixed\\(\\)\\.$#"
+			count: 1
+			path: src/CartConditions/Coupon.php
+
 		-
 			message: "#^Call to an undefined static method Igniter\\\\Cart\\\\Facades\\\\Cart\\:\\:content\\(\\)\\.$#"
 			count: 1
@@ -81,7 +111,7 @@ parameters:
 			path: src/CartConditions/Coupon.php
 
 		-
-			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Builder\\:\\:isEnabled\\(\\)\\.$#"
+			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Builder\\<Igniter\\\\Coupons\\\\Models\\\\Coupon\\>\\:\\:isEnabled\\(\\)\\.$#"
 			count: 1
 			path: src/Extension.php
 

diff --git a/src/CartConditions/Coupon.php b/src/CartConditions/Coupon.php
@@ -41,7 +41,7 @@ public function getValue()
 
     public function getModel()
     {
-        if (!strlen($couponCode = $this->getMetaData('code'))) {
+        if (!strlen($couponCode = $this->getMetaData('code', ''))) {
             return null;
         }
 
@@ -68,7 +68,7 @@ public function getApplicableItems($couponModel)
 
     public function onLoad()
     {
-        if (!strlen($this->getMetaData('code')) || self::$hasErrors) {
+        if (!strlen($this->getMetaData('code', '')) || self::$hasErrors) {
             return;
         }