Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriver: WebKitWebDriver: set correct browsername to avoid Failed to match capabilities #2340

Closed
wants to merge 1 commit into from

Conversation

bukowa
Copy link

@bukowa bukowa commented Jun 27, 2024

fixes tauri-apps/tauri#8828

This is really annoying, with previous wry example:

  1. Edgedriver doesn't care.
  2. WebKitWebDriver fails with Failed to match capabilities.
  3. Selenium won't allow undefined.

P.S WebKitWebDriver can run with bundled MiniBrowser if you set browserName to MiniBrowser

@bukowa bukowa requested a review from a team as a code owner June 27, 2024 08:16
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for tauri-v1 ready!

Name Link
🔨 Latest commit fe45283
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v1/deploys/667d1fceaee8260008e88cc7
😎 Deploy Preview https://deploy-preview-2340--tauri-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bukowa
Copy link
Author

bukowa commented Jun 27, 2024

This only happens in v1 but it doesn't matter as v1 won't work (prove me wrong) with newest webkitdriver anyway.
In v2 wry is required to match capabilities.

@bukowa bukowa closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant