feat(cli): support Trunk for iOS dev out of the box #11181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trunk only allows us to have a dynamic development server address via the TRUNK_SERVE_ADDRESS environment variable, to we must set it from the Tauri CLI in order to support it
Package Changes Through 37a1d59There are 3 changes which include tauri with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Sep 30, 2024
| "@tauri-apps/cli": patch:enhance | ||
| --- | ||
|
|
||
| Set the `TRUNK_SERVE_ADDRESS` environment variable when running on iOS physical devices to support Trunk. |
There was a problem hiding this comment.
I think we need to do the same for android, no? see #11137
There was a problem hiding this comment.
I'll investigate that one separately (need to get an android phone from someone here first)
amrbashir
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trunk only allows us to have a dynamic development server address via the TRUNK_SERVE_ADDRESS environment variable, to we must set it from the Tauri CLI in order to support it