fix(windows): TrayIcon allow show_menu_on_left_click #11729
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandercox
force-pushed
the
tray-show-menu-on-left-click-windows
branch
from
3254fd8
to
107adc1
Compare
amrbashir
approved these changes
Nov 18, 2024
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
show_menu_on_left_clickwas implemented for Windows in tauri-apps/tray-icon#199 but the tauri TrayBuilder didn't allow the usage yet when platform was not "macOS". Added theanytarget_osguard. And updated the comments inline with the changes made in the PR mentioned.