-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for querying customers and updating their emails #19
Open
jorgemanrubia
wants to merge
8
commits into
taxjar:master
Choose a base branch
from
basecamp:basecamp-additions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 751c97f)
Adding this option to support passing query params when listing customers as per: https://developer.helpscout.com/mailbox-api/endpoints/customers/list/
jorgemanrubia
force-pushed
the
basecamp-additions
branch
2 times, most recently
from
December 15, 2020 09:35
87c7243
to
e3d11a7
Compare
jorgemanrubia
force-pushed
the
basecamp-additions
branch
from
December 15, 2020 09:35
e3d11a7
to
d2c1a3f
Compare
jorgemanrubia
changed the title
Support finding customers and updating their emails
Support for querying customers and updating their emails
Dec 15, 2020
jorgemanrubia
force-pushed
the
basecamp-additions
branch
from
December 15, 2020 10:55
6f474d8
to
986e03f
Compare
2.4 version was the minimum for rubocop 0.93
|
I've made #25, maybe we can combine our efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds supports for two things:
Passing params for listing operations. I wanted to be able to use
query
params when finding customers. I think supporting params in general forlist
requests makes sense.Support for customer email updates
It also includes some changes for making the travis build pass:
rake
to deal with security advisory CVE-2020-8130 that was making Travis fail.Thanks for the nice lib!