Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for querying customers and updating their emails #19

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jorgemanrubia
Copy link

@jorgemanrubia jorgemanrubia commented Dec 15, 2020

This adds supports for two things:

  • Passing params for listing operations. I wanted to be able to use query params when finding customers. I think supporting params in general for list requests makes sense.

  • Support for customer email updates

It also includes some changes for making the travis build pass:

  • Upgrades rake to deal with security advisory CVE-2020-8130 that was making Travis fail.
  • Bump rubocop's ruby target version to make it work with version0.93 and make rubocop pass

Thanks for the nice lib!

(cherry picked from commit 751c97f)
Adding this option to support passing query params when
listing customers as per:

https://developer.helpscout.com/mailbox-api/endpoints/customers/list/
@jorgemanrubia jorgemanrubia force-pushed the basecamp-additions branch 2 times, most recently from 87c7243 to e3d11a7 Compare December 15, 2020 09:35
@jorgemanrubia jorgemanrubia changed the title Support finding customers and updating their emails Support for querying customers and updating their emails Dec 15, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@waghanza
Copy link

I've made #25, maybe we can combine our efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants