Fix UpdateOrderParams
for allow updating dollar amount values to zero
#14
+29
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #13
This makes it possible to update dollar amounts of an order/transaction to zero.
Normally I wouldn't request a breaking change at all, and this case we could get around that by create a new struct with the pointer versions and allowing someone to use either, but I feel since this is a bug, it's worth forcing the fix, otherwise (like in our case) failed transaction updates will go completely unnoticed.
I also added two helper functions, pulled straight from the AWS source for the same purpose:
https://github.com/aws/aws-sdk-go/blob/main/aws/convert_types.go
These helper functions make it easier to switch between the pointer of a type and the value of the type, which looks like this (from the updated example file)
This was tested in production via my fork already and I was able to confirm this fixed our issue.