Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect a proper error by response code #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jalkoby
Copy link

@jalkoby jalkoby commented Aug 25, 2022

In case of 502 response code TaxJar raises base TaxJar::Error rather than TaxJar::Error::ServerError which is more accurate and allows to handle only server side errors

In case of 502 response code TaxJar raises base TaxJar::Error rather than  TaxJar::Error::ServerError which is more accurate and allows to handle only server side errors
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jalkoby
Copy link
Author

jalkoby commented Nov 3, 2022

@CLAassistant the page doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants