Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: update github actions #3133

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Meta: update github actions #3133

merged 1 commit into from
Jul 26, 2023

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 26, 2023

This ensures the actions aren't running node 12, which will be removed soon.

@ljharb ljharb added the meta label Jul 26, 2023
@ljharb ljharb requested a review from a team July 26, 2023 22:27
bakkot
bakkot approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading it right, these are all node 16, which is EOL in less than two months.

But none of them have more recent versions, so... ship it I guess.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 26, 2023
@ljharb
Copy link
Member Author

ljharb commented Jul 26, 2023

yup, github's own actions are incredibly slow at keeping up to date, sadly, and that includes the node version base for custom actions :-(

@ljharb ljharb merged commit f688c6f into tc39:main Jul 26, 2023
6 checks passed
@ljharb ljharb deleted the actions-update branch July 26, 2023 22:38
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@ljharb
Meta: update github actions (tc39#3133)
c3bc7d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljharb @bakkot