Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Consistify capitalization re iterator wording #3469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Nov 7, 2024

It looks like PR #3459 missed these changes to capitalization and use of <em>.


Things I noticed but didn't change:

  • "Iterator instance objects": Not sure about that "I".

  • "an [Oo]bject that conforms to the IteratorResult interface": Change to "an IteratorResult object" (of which there are already many occurrences)?

The latter reminds me that the spec should perhaps have a sentence saying that an object that conforms to interface Foo can be called "a Foo object".

It looks like PR tc39#3459 missed these changes
to capitalization and use of "<em>".
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look correct to me. Thanks!

@michaelficarra
Copy link
Member

  • "Iterator instance objects": Not sure about that "I".

This is intentional.

The latter reminds me that the spec should perhaps have a sentence saying that an object that conforms to interface Foo can be called "a Foo object".

I would hope this goes without saying, but I'd be fine including such a sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants