Editorial: Inlined Intl.PluralRules's GetOperands AO. #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This AO was only called from the ResolvePlural AO, which immediately passed the Record it returns into the implementation-defined PluralRuleSelect AO. The revised version directly passes PluralRuleSelect the decimal String which was previously parsed by GetOperands. Implementations of PluralRuleSelect may (or may not) use something like GetOperands to determine the plural category returned. fixes tc39#635
gibson042
approved these changes
Sep 29, 2024
Co-authored-by: Richard Gibson <[email protected]>
|
Look good? @gibson042 |
gibson042
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetOperandswas only called from theResolvePluralAO, which immediately passed the Record returned byGetOperandsto the implementation-defined PluralRuleSelect AO. The revised version ofResolvePluraldirectly passesPluralRuleSelectthe decimal String which was previously parsed byGetOperands. Implementations ofPluralRuleSelectmay (or may not) use something likeGetOperandsto determine the correct plural category.fixes #635