Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

editorial: _escapedList_ mixes code units and code points #68

Closed
michaelficarra opened this issue Mar 23, 2024 · 2 comments
Closed

editorial: _escapedList_ mixes code units and code points #68

michaelficarra opened this issue Mar 23, 2024 · 2 comments

Comments

@michaelficarra
Copy link
Member

It'd probably be best to create a string through repeated string-concatenations and call UTF16EncodeCodePoint directly.
@ljharb
Copy link
Member

ljharb commented Mar 23, 2024

Good catch.

Your suggestion tho seems more complex than either converting the code units into code points while adding them, for example.

@ljharb
Copy link
Member

ljharb commented Mar 25, 2024

I think that this is fixed by #67. Will reopen if not.

@ljharb ljharb closed this as completed Mar 25, 2024
@michaelficarra michaelficarra mentioned this issue Mar 29, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @michaelficarra