Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

Editorial: Simplify algorithms by using strings rather than Lists #73

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Editorial: Simplify algorithms by using strings rather than Lists #73

merged 1 commit into from
Mar 29, 2024

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 mentioned this pull request Mar 28, 2024
Closed
33 tasks
@ljharb
Copy link
Member

ljharb commented Mar 28, 2024

To me this really isn't simplified - using lists is much cleaner and easier to understand to me than continually mutating a string.

I'll defer to the @tc39/ecma262-editors, though.

michaelficarra
michaelficarra approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is what I was suggesting in #68.

@ljharb ljharb requested review from syg and bakkot March 29, 2024 16:46
@ljharb ljharb force-pushed the 2024-03-use-strings branch from 8795ffb to aee5a2c Compare March 29, 2024 19:44
@ljharb ljharb merged commit aee5a2c into tc39:main Mar 29, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gibson042 @ljharb @syg @michaelficarra @bakkot