Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating catch to 2.13.10 #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeterWaIIace
Copy link

Catch 2.9.2 is not compatible with Apple Silicon causing compilation errors on Mac. Updating catch to 2.13.10 solves compilation errors.

Trying to build 2.9.2 on apple silicon causes similar error to: CoatiSoftware/Sourcetrail#1185

Copy link
Contributor

@kimci86 kimci86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm compiling tests on Apple Silicon platform fails, this PR fixes it and it provides the latest Catch2 release from v2.x branch. This is good to merge!

@kimci86
Copy link
Contributor

kimci86 commented Jan 28, 2023

@tcbrindle Could you merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants