Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase against Element Android v1.6.10 #1009

Merged
merged 49 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
4debc49
Change jitsi-meet constants URL
Amir-yazdanmanesh Oct 28, 2023
7755da8
Move crypto migration
yostyle Oct 13, 2023
31d3b9d
Add changelog
yostyle Oct 13, 2023
f6ca7e5
Merge tag 'v1.6.8' into develop
bmarty Nov 28, 2023
bb9d1fc
version++
bmarty Nov 28, 2023
fb077d5
Implement Mobile Device Manager feature with 3 keys.
bmarty Nov 30, 2023
5987ca9
changelog
bmarty Nov 30, 2023
8e0c503
Support Functional members #3736
bmarty Nov 28, 2023
778dab7
Cleanup and safer Json model.
bmarty Dec 4, 2023
7e2b01b
Add link to spec in changelog.
bmarty Dec 4, 2023
882020f
Fix test compilation issue.
bmarty Dec 4, 2023
6452b5c
Make DefaultMdmService a singleton and use Binds instead of Provides.
bmarty Dec 4, 2023
bb86660
Fix test compilation issue.
bmarty Dec 5, 2023
5e4b8ed
Merge pull request #8700 from vector-im/feature/fga/handle_functional…
bmarty Dec 6, 2023
4d5fefa
Fix issue on chinese language resource.
bmarty Dec 6, 2023
7e40b93
Sync analytics plan
bmarty Dec 11, 2023
9c6fbcd
Sync SAS Strings
bmarty Dec 11, 2023
9652932
Merge pull request #8706 from vector-im/sync-sas-strings
bmarty Dec 11, 2023
1c1c89f
Merge pull request #8698 from vector-im/feature/bma/mdm
bmarty Dec 11, 2023
6d65a74
Organization renaming: replace all `https://github.com/vector-im` by…
bmarty Dec 13, 2023
b6e3e87
Organization renaming: `vector-im` -> `element-hq`
bmarty Dec 13, 2023
d145c31
Bump io.element.android:wysiwyg from 2.14.1 to 2.22.0
dependabot[bot] Dec 14, 2023
7f8e73e
Merge branch 'element-hq:develop' into yostyle/fix_crypto_migration
yostyle Dec 15, 2023
18ccc25
fix lint
yostyle Dec 15, 2023
431a1a6
Merge pull request #8672 from Amir-yazdanmanesh/develop
bmarty Dec 15, 2023
f3c6535
Merge branch 'element-hq:develop' into yostyle/fix_crypto_migration
yostyle Dec 18, 2023
fac8dd3
RTE: fix API break...
bmarty Dec 20, 2023
644587a
Fix crash...
bmarty Dec 20, 2023
6feee61
Merge pull request #8711 from element-hq/dependabot/gradle/io.element…
bmarty Dec 20, 2023
abccc7d
Merge pull request #8710 from element-hq/feature/bma/elementHq
bmarty Dec 21, 2023
7242ad4
No need to use `also` here.
bmarty Dec 21, 2023
d610f75
Fix compilation issue.
bmarty Dec 21, 2023
e818f86
Merge pull request #8666 from yostyle/yostyle/fix_crypto_migration
bmarty Dec 21, 2023
03966f1
Fix KDoc (I know I should not edit this, but its fine)
bmarty Dec 21, 2023
25d1945
Merge pull request #8577 from element-hq/sync-analytics-plan
bmarty Dec 21, 2023
dff9b82
Revert change on those files, that should fix Weblate conflict
bmarty Dec 22, 2023
c46b314
Try fixing exodus CI job (#8721)
jmartinesp Jan 2, 2024
b72039e
Fix a bunch of issues related to edition and reply #5969
ganfra Dec 20, 2023
320aae1
Also fix pills with rich text editor
ganfra Dec 20, 2023
2ada4c8
Fix quality
ganfra Dec 21, 2023
60d4221
GH actions: remove triaging process and old GH projects
manuroe Jan 2, 2024
7a2520b
Merge pull request #8724 from element-hq/manu/issue_triaging_cleanup
manuroe Jan 2, 2024
e596196
Merge pull request #8716 from element-hq/feature/fga/fix_event_editio…
ganfra Jan 2, 2024
9249131
Bump io.element.android:wysiwyg from 2.22.0 to 2.24.0
dependabot[bot] Jan 5, 2024
4c8ffbd
Merge pull request #8727 from element-hq/dependabot/gradle/io.element…
bmarty Jan 8, 2024
5c6e1d5
Changelog for version 1.6.10
bmarty Jan 9, 2024
ac79b2e
Adding fastlane file for version 1.6.10
bmarty Jan 9, 2024
493093c
Merge branch 'release/1.6.10' into main
bmarty Jan 9, 2024
4049ace
Merge element-hq/element-android v1.6.10 into element-rebase
yostyle Jan 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
blank_issues_enabled: true
contact_links:
- name: Enhancement or feature request
url: https://github.com/vector-im/element-meta/discussions/categories/ideas
url: https://github.com/element-hq/element-meta/discussions/categories/ideas
about: Do you have a suggestion or feature request?
- name: Element Android Community Support
url: https://matrix.to/#/#element-android:matrix.org
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ body:
- [ ] Check the update of the store descriptions (using Google Translate if necessary) to ensure that the changes are acceptable to be published to the stores.
- [ ] While Weblate is locked, and after the PR from Weblate has been merged, handle all the TODOs in the main `strings.xml` file
- [ ] Run the script `./tools/release/pushPlayStoreMetaData.sh`. You can check in the GooglePlay console the Activity log to check the effect.
- [ ] Ensure all [the required PRs](https://github.com/vector-im/element-android/pulls?q=is%3Aopen+is%3Apr+label%3AZ-NextRelease) have been merged
- [ ] Ensure all [the required PRs](https://github.com/element-hq/element-android/pulls?q=is%3Aopen+is%3Apr+label%3AZ-NextRelease) have been merged

### Do the release

Expand Down
7 changes: 3 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,10 @@ Uncomment this markdown table below and edit the last line `|||`:

- [ ] Changes has been tested on an Android device or Android emulator with API 21
- [ ] UI change has been tested on both light and dark themes
- [ ] Accessibility has been taken into account. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#accessibility
- [ ] Accessibility has been taken into account. See https://github.com/tchapgouv/tchap-android/blob/develop/CONTRIBUTING.md#accessibility
- [ ] Pull request is based on the develop branch
- [ ] Pull request updates [TCHAP_CHANGES.md](https://github.com/tchapgouv/tchap-android-v2/blob/develop/TCHAP_CHANGES.md)
- [ ] Pull request includes a new file under ./changelog.d. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#changelog
- [ ] Pull request includes a new file under ./changelog.d. See https://github.com/tchapgouv/tchap-android/blob/develop/CONTRIBUTING.md#changelog
- [ ] Pull request includes screenshots or videos if containing UI changes
- [ ] Pull request includes a [sign off](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off)
- [ ] You've made a self review of your PR
- [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test [UiAllScreensSanityTest.allScreensTest()](https://github.com/tchapgouv/tchap-android-v2/blob/develop/vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt)
- [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test [UiAllScreensSanityTest.allScreensTest()](https://github.com/tchapgouv/tchap-android/blob/develop/vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt)
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ updates:
# Tchap: Disable this script for Tchap
open-pull-requests-limit: 0
reviewers:
- "vector-im/element-android-reviewers"
- "element-hq/element-android-reviewers"
ignore:
- dependency-name: "*"
# Updates for Gradle dependencies used in the app
Expand All @@ -24,7 +24,7 @@ updates:
# Tchap: Disable this script for Tchap
open-pull-requests-limit: 0
reviewers:
- "vector-im/element-android-reviewers"
- "element-hq/element-android-reviewers"
allow:
- dependency-name: "io.element.android:wysiwyg"
- dependency-name: "org.matrix.rustcomponents:crypto-android"
10 changes: 8 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,18 @@ jobs:
- name: Execute exodus-standalone
uses: docker://exodusprivacy/exodus-standalone:latest
with:
args: /github/workspace/${{ env.TARGET_FOLDER }}/release/${{ steps.list-apks.outputs.FIRST_APK_NAME }} -j -o /github/workspace/exodus.json
# Don't fail when finding trackers so they can be reported later
args: /github/workspace/${{ env.TARGET_FOLDER }}/release/${{ steps.list-apks.outputs.FIRST_APK_NAME }} -j -o /github/workspace/exodus.json -e 0
- name: Upload exodus json report
uses: actions/upload-artifact@v3
with:
name: exodus.json
path: |
exodus.json
- name: Check for trackers
run: "jq -e '.trackers == []' exodus.json > /dev/null || { echo '::error static analysis identified user tracking library' ; exit 1; }"
env:
SENTRY_ID: 447
# Should only contain a Sentry item
run: |
TRACKER_IDS=$(jq ".trackers[] | .id" exodus.json)
[ $TRACKER_IDS = ${{ env.SENTRY_ID }} ] || { echo '::error static analysis identified user tracking library' ; exit 1; }
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
jobs:
nightly:
# Tchap: Skip nightly
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
name: Build and publish nightly Gplay APK to Firebase
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/post-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
matrix:
api-level: [ 28 ]
# Tchap: Disabled for now
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
# No concurrency required, runs every time on a schedule.
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
- should-i-run
- ui-tests
# Tchap: Disabled for now
if: github.repository == 'vector-im/element-android' && always() && (needs.should-i-run.result == 'success' ) && (needs.ui-tests.result != 'success')
if: github.repository == 'element-hq/element-android' && always() && (needs.should-i-run.result == 'success' ) && (needs.ui-tests.result != 'success')
# No concurrency required, runs every time on a schedule.
steps:
- uses: michaelkaye/[email protected]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/sync-from-external-sources.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
sync-emojis:
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
# No concurrency required, runs every time on a schedule.
steps:
- uses: actions/checkout@v3
Expand All @@ -36,7 +36,7 @@ jobs:
sync-sas-strings:
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
# No concurrency required, runs every time on a schedule.
steps:
- uses: actions/checkout@v3
Expand All @@ -62,7 +62,7 @@ jobs:
sync-analytics-plan:
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
# No concurrency required, runs every time on a schedule.
steps:
- uses: actions/checkout@v3
Expand Down
25 changes: 0 additions & 25 deletions .github/workflows/triage-incoming.yml

This file was deleted.

97 changes: 3 additions & 94 deletions .github/workflows/triage-labelled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,12 @@ jobs:
labels: ['Help Wanted']
})

move_needs_info_issues:
name: X-Needs-Info issues to Need info column on triage board
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'vector-im/element-android'
steps:
- uses: konradpabjan/move-labeled-or-milestoned-issue@219d384e03fa4b6460cd24f9f37d19eb033a4338
with:
action-token: "${{ secrets.ELEMENT_BOT_TOKEN }}"
project-url: "https://github.com/vector-im/element-android/projects/4"
column-name: "Need info"
label-name: "X-Needs-Info"

add_design_issues_to_project:
name: X-Needs-Design to Design project board
runs-on: ubuntu-latest
# Skip in forks
if: >
github.repository == 'vector-im/element-android' &&
github.repository == 'element-hq/element-android' &&
contains(github.event.issue.labels.*.name, 'X-Needs-Design') &&
(contains(github.event.issue.labels.*.name, 'S-Critical') &&
(contains(github.event.issue.labels.*.name, 'O-Frequent') ||
Expand All @@ -76,7 +63,7 @@ jobs:
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/18
project-url: https://github.com/orgs/element-hq/projects/18
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

add_product_issues:
Expand All @@ -87,84 +74,6 @@ jobs:
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/28
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

move_element_x_issues:
name: ElementX issues to ElementX project board
runs-on: ubuntu-latest
# Skip in forks
if: >
github.repository == 'vector-im/element-android' &&
(contains(github.event.issue.labels.*.name, 'Z-BBQ-Alpha') ||
contains(github.event.issue.labels.*.name, 'Z-BBQ-Beta') ||
contains(github.event.issue.labels.*.name, 'Z-BBQ-Release') ||
contains(github.event.issue.labels.*.name, 'Z-Banquet-Alpha') ||
contains(github.event.issue.labels.*.name, 'Z-Banquet-Beta') ||
contains(github.event.issue.labels.*.name, 'Z-Banquet-Release'))
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/43
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

ex_plorers:
name: Add labelled issues to X-Plorer project
runs-on: ubuntu-latest
if: >
contains(github.event.issue.labels.*.name, 'Team: Element X Feature')
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/73
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

ps_features1:
name: Add labelled issues to PS features team 1
runs-on: ubuntu-latest
if: >
contains(github.event.issue.labels.*.name, 'A-Polls') ||
contains(github.event.issue.labels.*.name, 'A-Location-Sharing') ||
(contains(github.event.issue.labels.*.name, 'A-Voice-Messages') &&
!contains(github.event.issue.labels.*.name, 'A-Broadcast')) ||
(contains(github.event.issue.labels.*.name, 'A-Session-Mgmt') &&
contains(github.event.issue.labels.*.name, 'A-User-Settings'))
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/56
project-url: https://github.com/orgs/element-hq/projects/28
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

ps_features2:
name: Add labelled issues to PS features team 2
runs-on: ubuntu-latest
if: >
contains(github.event.issue.labels.*.name, 'A-DM-Start') ||
contains(github.event.issue.labels.*.name, 'A-Broadcast')
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/58
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

ps_features3:
name: Add labelled issues to PS features team 3
runs-on: ubuntu-latest
if: >
contains(github.event.issue.labels.*.name, 'A-Rich-Text-Editor')
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/57
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}

voip:
name: Add labelled issues to VoIP project board
runs-on: ubuntu-latest
if: >
contains(github.event.issue.labels.*.name, 'Team: VoIP')
steps:
- uses: actions/add-to-project@main
with:
project-url: https://github.com/orgs/vector-im/projects/41
github-token: ${{ secrets.ELEMENT_BOT_TOKEN }}
8 changes: 4 additions & 4 deletions .github/workflows/triage-move-review-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ jobs:
name: Move PRs asking for design review to the design board
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
steps:
- uses: octokit/[email protected]
id: find_team_members
with:
headers: '{"GraphQL-Features": "projects_next_graphql"}'
query: |
query find_team_members($team: String!) {
organization(login: "vector-im") {
organization(login: "element-hq") {
team(slug: $team) {
members {
nodes {
Expand Down Expand Up @@ -77,15 +77,15 @@ jobs:
name: Move PRs asking for product review to the product board
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
steps:
- uses: octokit/[email protected]
id: find_team_members
with:
headers: '{"GraphQL-Features": "projects_next_graphql"}'
query: |
query find_team_members($team: String!) {
organization(login: "vector-im") {
organization(login: "element-hq") {
team(slug: $team) {
members {
nodes {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/triage-priority-bugs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
# Skip in forks
if: >
github.repository == 'vector-im/element-android' &&
github.repository == 'element-hq/element-android' &&
(!contains(github.event.issue.labels.*.name, 'A-E2EE') &&
!contains(github.event.issue.labels.*.name, 'A-E2EE-Cross-Signing') &&
!contains(github.event.issue.labels.*.name, 'A-E2EE-Dehydration') &&
Expand All @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-latest
# Skip in forks
if: >
github.repository == 'vector-im/element-android' &&
github.repository == 'element-hq/element-android' &&
(contains(github.event.issue.labels.*.name, 'Z-UISI') ||
(contains(github.event.issue.labels.*.name, 'A-E2EE') ||
contains(github.event.issue.labels.*.name, 'A-E2EE-Cross-Signing') ||
Expand Down
62 changes: 0 additions & 62 deletions .github/workflows/triage-unlabelled.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/update-gradle-wrapper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Update Gradle Wrapper
uses: gradle-update/update-gradle-wrapper-action@v1
# Skip in forks
if: github.repository == 'vector-im/element-android'
if: github.repository == 'element-hq/element-android'
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
target-branch: develop
Loading
Loading