Merge pull request #937 from tchapgouv/924-activer-la-signature-crois…

…ee-automatiquement-a-la-creation-de-compte Nouvelle implémentation de l'activation automatique du cross-signing …
tchapgouv · Nov 29, 2023 · 91336a4 · 91336a4
2 parents f303ea3 + 359e1b4
commit 91336a4
Showing 1 changed file with 51 additions and 17 deletions.
diff --git a/Riot/Modules/Home/HomeViewController.m b/Riot/Modules/Home/HomeViewController.m
@@ -40,7 +40,7 @@ @interface HomeViewController () <SecureBackupSetupCoordinatorBridgePresenterDel
     CGFloat selectedCollectionViewContentOffset;
 
     // Tchap: initial sync done listener
-    id tchapInitialSyncDoneListener;
+    id tchapSyncDoneListener;
 }
 
 @property (nonatomic, strong) SecureBackupSetupCoordinatorBridgePresenter *secureBackupSetupCoordinatorBridgePresenter;
@@ -104,20 +104,55 @@ - (void)viewDidLoad
 
     // Change the table data source. It must be the home view controller itself.
     self.recentsTableView.dataSource = self;
-
-    // Tchap: listen to Tchap InitialSyncDone notification added by Tchap in Matrix SDK.
-    if (tchapInitialSyncDoneListener == nil)
+}
+
+// Tchap: set-up cross-signing auto-activation
+- (void)tchapSetupCrossSigningAutoActivation
+{
+    // Tchap: listen to Tchap syncDone notification to check the status of the cross-signing after account info are updated.
+    if (tchapSyncDoneListener == nil)
     {
-        tchapInitialSyncDoneListener = [NSNotificationCenter.defaultCenter addObserverForName:kTchapMXSessionInitialSyncDone
-                                                                                       object:nil
-                                                                                        queue:NSOperationQueue.mainQueue
-                                                                                   usingBlock:^(NSNotification * _Nonnull notification) {
-            // Try to force activate cross-signing after initial sync.
-            [self showCrossSigningSetup];
+        __weak typeof(self) weakSelf = self;
+
+        tchapSyncDoneListener = [NSNotificationCenter.defaultCenter addObserverForName:kMXSessionDidSyncNotification
+                                                                                object:nil
+                                                                                 queue:NSOperationQueue.mainQueue
+                                                                            usingBlock:^(NSNotification * _Nonnull notification) {
+
+            __strong __typeof(weakSelf)strongSelf = weakSelf;
+            MXSession *session = strongSelf.mainSession;
+
+            // Remove listener after first invocation.
+            [self tchapUnsetupCrossSigningAutoActivation];
+
+            // Try to force activate cross-signing after sync if:
+            //   - device is the only one listed on the account (no risk of conflict with other devices)
+            //   - Cross-signing is not enabled for this account.
+            //   - or Cross-signing exists on the account but is not trusted by this device. The account password can be asked to activate cross-signing in this case.
+            NSString *currentUserId = session.myUserId;
+            MXCrossSigningState state = session.crypto.crossSigning.state;
+            if (currentUserId != nil
+                && [session.crypto devicesForUser:currentUserId].count < 2
+                && (session.crypto.crossSigning.state == MXCrossSigningStateNotBootstrapped || session.crypto.crossSigning.state == MXCrossSigningStateCrossSigningExists) )
+            {
+                [strongSelf showCrossSigningSetup];
+            }
         }];
     }
 }
 
+// Tchap: remove intial sync done listener
+- (void)tchapUnsetupCrossSigningAutoActivation
+{
+    if (tchapSyncDoneListener)
+    {
+        [NSNotificationCenter.defaultCenter removeObserver:tchapSyncDoneListener
+                                                      name:kMXSessionDidSyncNotification
+                                                    object:nil];
+        tchapSyncDoneListener = nil;
+    }
+}
+
 - (void)viewWillAppear:(BOOL)animated
 {
     [super viewWillAppear:animated];
@@ -138,6 +173,10 @@ - (void)viewWillAppear:(BOOL)animated
         [recentsDataSource searchWithPatterns:nil];
         [self.recentsSearchBar setText:nil];
     }
+
+    // Tchap: set-up cross-signing auto-activation in viewWillAppear rather than in viewDidLoad
+    // because this controller is only created once and never released!
+    [self tchapSetupCrossSigningAutoActivation];
 }
 
 - (void)viewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id <UIViewControllerTransitionCoordinator>)coordinator
@@ -154,13 +193,8 @@ - (void)viewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id <UIV
 - (void)destroy
 {
     // Tchap: remove intial sync done listener
-    if (tchapInitialSyncDoneListener)
-    {
-        [NSNotificationCenter.defaultCenter removeObserver:tchapInitialSyncDoneListener
-                                                      name:kTchapMXSessionInitialSyncDone
-                                                    object:nil];
-        tchapInitialSyncDoneListener = nil;
-    }
+    [self tchapUnsetupCrossSigningAutoActivation];
+
     [super destroy];
 }