Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppression du filtrage de notification VoIP sur l'age de la notifica… #1077

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Suppression du filtrage de notification VoIP sur l'age de la notifica… #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions RiotNSE/NotificationService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class NotificationService: UNNotificationServiceExtension {
enum Constants {
static let voipPushRequestTimeout: TimeInterval = 15
static let timeNeededToSendVoIPPushes: TimeInterval = 20
static let tchapCallInviteNotificationDiscardDelta = 10.0 // Tchap: max age of call event before ignoring it
}
}

Expand Down Expand Up @@ -863,17 +862,6 @@ class NotificationService: UNNotificationServiceExtension {

// Starting from iOS 14.5, SDK can "Reports a new incoming call after your notification service extension decrypts a VoIP call request."
// See: https://developer.apple.com/documentation/callkit/cxprovider/3727263-reportnewincomingvoippushpayload

// from Element X : https://github.com/element-hq/element-x-ios/pull/2862/files#diff-1ff0fcebaadd2768e042e7bbafc1321cc5a73089ac1692dc3749492fa2881d91R203
// Checks if it's still time relevant (max 10 seconds old) and whether it should ring
//
// Should prevent ghost ringing when old m.call.invite are dispatched lately

let timestamp = Date(timeIntervalSince1970: TimeInterval(event.age / 1000))
guard abs(timestamp.timeIntervalSinceNow) < NSE.Constants.tchapCallInviteNotificationDiscardDelta else {
MXLog.info("Call notification is too old, handling as push notification")
return
}

// Build th payload expected by the application.
var payload = [String: String]()
Expand Down
1 change: 1 addition & 0 deletions changelog.d/1076.change
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Suppression du filtrage de notification VoIP sur l'age de la notification. Ne fonctionnait pas correctement sur Tchap.
Loading