970 etude activer la geolocalisation #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 27, 2024 17:11
… bon fournisseur de fonds de carte
…partage de localisation en temps réel)
added 4 commits
March 11, 2024 18:25
yostyle
reviewed
Mar 26, 2024
Comment on lines
+262
to
+268
| # - "Location" | ||
| # - "RoomViewController+LocationSharing.swift" | ||
| # - "TimelineCells/LocationView" | ||
| # - "TimelineCells/Styles/Plain/Cells/Location" | ||
| # - "TimelineCells/Styles/Bubble/Cells/Location" | ||
| # - "Views/BubbleCells/KeyVerification/SizingViewHeight.swift" | ||
| # - "Views/BubbleCells/Location" |
There was a problem hiding this comment.
Pourquoi ces commentaires ?
There was a problem hiding this comment.
C'est dans une rubrique exclude;
C'est donc pour qu'ils ne soient pas exclus car ils sont nécessaires à la geoloc (comme leurs noms le laisse supposer).
There was a problem hiding this comment.
tu aurais pu les supprimer les lignes ?
There was a problem hiding this comment.
Oui, mais elles sont présentes dans le fichier source Element.
| @@ -65,7 +65,7 @@ targets: | |||
| - path: ../Riot/Categories/Codable.swift | |||
| - path: ../Riot/Assets/en.lproj/Vector.strings | |||
| - path: ../Riot/Modules/Analytics/AnalyticsScreen.swift | |||
| - path: ../Riot/Modules/LocationSharing/LocationAuthorizationStatus.swift | |||
There was a problem hiding this comment.
Tu n'as pas besoin de ce path dans la target ?
There was a problem hiding this comment.
Non, car ce fichier est implicitement inclus par la ligne - path: ../Riot/Modules/LocationSharing/ qui inclus le contenu du dossier récursivement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #970