chore(test): rename mockFeatureConfig and refacto

test/unit-tests/tchap/components/views/rooms/RoomHeaders-test.tsx

@@ -23,13 +23,15 @@ describe("RoomHeader", () => {
     const featurethreadName: string = "feature_thread";
     const homeserverName: string = "my.home.server";
 
-    const mockFeatureConfig = (homeservers: string[], feature: string) => {
+    const addHomeserverToMockConfig = (homeservers: string[], feature: string) => {
         // mock SdkConfig.get("tchap_features")
         const config: ConfigOptions = { tchap_features: {} };
         config.tchap_features[feature] = homeservers;
         SdkConfig.put(config);
     };
 
+    const getComponent = () => render(<RoomHeader room={room} />, getWrapper());
+
     beforeEach(async () => {
         stubClient();
         room = new Room(ROOM_ID, MatrixClientPeg.get()!, "@alice:example.org", {
@@ -40,8 +42,6 @@ describe("RoomHeader", () => {
         } as unknown as DMRoomMap);
     });
 
-    const getComponent = () => render(<RoomHeader room={room} />, getWrapper());
-
     afterEach(() => {
         SdkConfig.reset();
         jest.restoreAllMocks();
@@ -53,15 +53,15 @@ describe("RoomHeader", () => {
     });
 
     it("display well the thread button when feature is activated", async () => {
-        mockFeatureConfig([homeserverName], featurethreadName);
+        addHomeserverToMockConfig([homeserverName], featurethreadName);
 
         getComponent();
 
         expect(screen.queryByTestId("room-header-thread-button")).toBeInTheDocument;
     });
 
     it("hides the thread button when feature is deactivated", async () => {
-        mockFeatureConfig(["other.homeserver"], featurethreadName);
+        addHomeserverToMockConfig(["other.homeserver"], featurethreadName);
 
         getComponent();
 

test/unit-tests/tchap/components/views/settings/Notifications-test.tsx

@@ -204,7 +204,7 @@ describe("<Notifications />", () => {
 
     const testEmail = "[email protected]";
 
-    const mockFeatureConfig = (homeservers: string[], featureList: string[] = []) => {
+    const addHomeserverToMockConfig = (homeservers: string[], featureList: string[] = []) => {
         // mock SdkConfig.get("tchap_features")
         const config: ConfigOptions = { tchap_features: {} };
         featureList.forEach((feature) => (config.tchap_features[feature] = homeservers));
@@ -238,7 +238,7 @@ describe("<Notifications />", () => {
 
     it("display well the caption when email notification feature is activated", async () => {
         // activate email notification in the config, otherwise the section won't appear
-        mockFeatureConfig([homeserverName], [featureEmailName]);
+        addHomeserverToMockConfig([homeserverName], [featureEmailName]);
 
         await getComponentAndWait();
 
@@ -254,7 +254,7 @@ describe("<Notifications />", () => {
     });
 
     it("hides well the caption when email notification feature is deactivated for this homeserver", async () => {
-        mockFeatureConfig([homeserverName]);
+        addHomeserverToMockConfig([homeserverName]);
 
         await getComponentAndWait();
 
@@ -266,7 +266,7 @@ describe("<Notifications />", () => {
     });
 
     it("hides well the caption when email notification feature is not activated for this homeserver", async () => {
-        mockFeatureConfig(["other.server.fr"], [featureEmailName]);
+        addHomeserverToMockConfig(["other.server.fr"], [featureEmailName]);
 
         await getComponentAndWait();
 
@@ -278,7 +278,7 @@ describe("<Notifications />", () => {
     });
 
     it("display well the tac notification switch when feature is activated", async () => {
-        mockFeatureConfig([homeserverName], [featurethreadName]);
+        addHomeserverToMockConfig([homeserverName], [featurethreadName]);
 
         await getComponentAndWait();
 
@@ -288,7 +288,7 @@ describe("<Notifications />", () => {
     });
 
     it("display hides the tac notification switch when feature is deactivated", async () => {
-        mockFeatureConfig([homeserverName]);
+        addHomeserverToMockConfig([homeserverName]);
 
         await getComponentAndWait();
 

test/unit-tests/tchap/components/views/spaces/SpacePanel-test.tsx

@@ -13,7 +13,7 @@ describe("<SpacePanel />", () => {
     const featureName: string = "feature_thread";
     const homeserverName: string = "my.home.server";
 
-    const mockFeatureConfig = (homeservers: string[]) => {
+    const addHomeserverToMockConfig = (homeservers: string[]) => {
         // mock SdkConfig.get("tchap_features")
         const config: ConfigOptions = { tchap_features: {} };
         config.tchap_features[featureName] = homeservers;
@@ -32,14 +32,14 @@ describe("<SpacePanel />", () => {
     });
 
     it("returns true when the the homeserver include thread feature", () => {
-        mockFeatureConfig([homeserverName]);
+        addHomeserverToMockConfig([homeserverName]);
         const { container } = renderSpacePanel();
 
         expect(container.getElementsByClassName("mx_ThreadsActivityCentre_container").length).toBe(1);
     });
 
     it("returns false when the the homeserver doesnt include thread feature", async () => {
-        mockFeatureConfig(["other.homeserver"]);
+        addHomeserverToMockConfig(["other.homeserver"]);
         const { container } = renderSpacePanel();
 
         expect(container.getElementsByClassName("mx_ThreadsActivityCentre_container").length).toBe(0);