-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email to all rageshakes #946
Merged
estellecomment
merged 17 commits into
develop_tchap
from
920-add-email-to-all-rageshakes
Apr 8, 2024
Merged
Add email to all rageshakes #946
estellecomment
merged 17 commits into
develop_tchap
from
920-add-email-to-all-rageshakes
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
MarcWadai
reviewed
Apr 8, 2024
MarcWadai
reviewed
Apr 8, 2024
MarcWadai
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vraiment trop trop cool pour units tests!! GG !!! 👍 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #920
Refactor the bug-reporting patch to cover all code flows.
There are two kinds of rageshakes :
For the two kinds, add email + appname.
The BugReportDialog still has to add the voip info, and customize the UI.
LegacyCallEvent (for voip) is unchanged in this PR.
Diagram of what's going on if it helps :)
Tests :
BugReportDialog :
Submit-rageshake
submitFeeback : Email and app name are passed to httpreqLegacyCallEvent