Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email to all rageshakes #946

Merged
merged 17 commits into from
Apr 8, 2024

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Mar 22, 2024

Issue : #920

Refactor the bug-reporting patch to cover all code flows.

There are two kinds of rageshakes :

  • feedback (from "Feedback"/"Commentaire" in user menu) (we are going to remove it Remove the "Commentaire" feature #938)
  • bugreport (from "Report a problem" in user menu, from "Report a problem" after a voip call, from auto-rageshake-on-uisi).

For the two kinds, add email + appname.

The BugReportDialog still has to add the voip info, and customize the UI.
LegacyCallEvent (for voip) is unchanged in this PR.

Diagram of what's going on if it helps :)
image

Tests :
BugReportDialog :

  • UI changes : partial snapshot ?
  • submit-rageshake.sendBugReport is called, with voip fields if needed

Submit-rageshake

  • sendBugReport : Voip fields are passed to httpreq if present
  • sendBugReport : Email and app name are passed to httpreq
  • submitFeeback : Email and app name are passed to httpreq

LegacyCallEvent

  • button is shown after finished successful call
  • clicking button opens BugreportDialog, and passes "voip" in the props

@estellecomment estellecomment marked this pull request as ready for review April 4, 2024 13:18
Copy link
Contributor

@MarcWadai MarcWadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vraiment trop trop cool pour units tests!! GG !!! 👍 👍

@estellecomment estellecomment merged commit 44c9e96 into develop_tchap Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants