Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voip): hide video button when feature not active on homeserver #995

Merged
merged 1 commit into from
May 7, 2024

Conversation

MarcWadai
Copy link
Contributor

@MarcWadai MarcWadai commented May 2, 2024

fix #952

Description

When in a call, the video button was visible from web to web call even if the feature was not activated in the config.
Added a check in the component to hide the button depending on the config

Test

  • unit tests for showing and hiding the button depending on the config
  • manual test when calling and activating/deactivating the homeserver feature

@MarcWadai MarcWadai force-pushed the 952-hide-video-button-on-call-screen branch from 1a99095 to 78c82c7 Compare May 6, 2024 08:16
@MarcWadai MarcWadai force-pushed the 952-hide-video-button-on-call-screen branch from 78c82c7 to c3608f7 Compare May 6, 2024 10:45
@NicolasBuquet NicolasBuquet self-requested a review May 7, 2024 08:40
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcWadai MarcWadai merged commit 35b58cc into develop_tchap May 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voip : video calls are possible from web to web
2 participants