feat: upgrade to Java 17 #1279
feat: upgrade to Java 17 #1279
Conversation
* Update node to the latest LTS version * Replace node-sass with sass * Also use the correct version of react-test-renderer. * Update react scripts so we don't use insecure hashing functions * Do not check eslint for production build See tchiotludo#1243 for more information.
Co-authored-by: alozano3 <[email protected]>
Co-authored-by: Ludovic DEHON <[email protected]>
|
The best for the JDK will be to add a For the compatibility with 11, I think to force upgrade and to provide only a 17 version for now. Codebase will not use features from 17 for now, and will wait to see if people is complaining on that. Anyway, I'm almost people will complain (when I see people creating ticket with akhq version 0.14 🙄) |
|
@loicmathieu you don't add the jdk image? |
|
@tchiotludo no, I don't know how to do it exactly and don't have time now to investiguate. If you want I can provide a separate PR for it but you need to explain to me how you make the release, as fas as I understand the workflow tags the images based on GIT tags. As there will not be different GIT tags for JRE vs JDK images more tags should be added manually right ? |
|
done in #1615 |
This PR updates AKHQ to Java 17.
@tchiotludo an alternative can be to update only the container to 17 and build it for both 11 and 17 so compatibility for 11 is kept in case someone deploy it via it's JAR and not a Docker container.
We discuss the possibility to provides both a container with the JRE and the JDK, I didn't do it because I have no idea how your container is built and deployed. May I add a second Dockerfile ?