Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(groups): improve consumer groups loading #1889

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

AlexisSouquiere
Copy link
Collaborator

@AlexisSouquiere AlexisSouquiere commented Aug 1, 2024

Add a dropdown list on the topic screen/consumer groups tab to allow people selecting "Hide empty consumer groups".
This option fixes issues on this screen with cluster containing a lot of consumer groups because we were looping over all the consumer groups and requesting the cluster for their offsets to find the right topics.

Ignoring empty consumer groups allows AKHQ to give the response quickly because we will search for the topic directly in the member assignation instead of having also the check in the groups offsets (for empty consumer groups)

image
  • Add the possibility to choose the default value (like the topic list view) in the application.yml (general settings or by cluster) and in the settings screen
image
  • Fix consumer group loading in topic list table
    Same issue as the previous one, with a lot of consumer groups, the consumer groups column in the topic list table takes a lot of time to show the result (when you don't reach a timeout).
image

By reusing the new "Consumer Groups Default View", AKHQ will now be able to show the active consumer groups quickly

On a cluster with 1500+ consumer groups, it allows us to finally see (at least) the active groups in few seconds

@AlexisSouquiere AlexisSouquiere changed the title Feat/improve topic consumer groups feat(groups): improve consumer groups tab loading on topic screen Aug 1, 2024
@AlexisSouquiere AlexisSouquiere changed the title feat(groups): improve consumer groups tab loading on topic screen feat(groups): improve consumer groups loading Aug 6, 2024
@AlexisSouquiere AlexisSouquiere marked this pull request as ready for review August 6, 2024 12:34
@tchiotludo
Copy link
Owner

oups, you could rebase and merge @AlexisSouquiere ?
Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Unable to display the consumer groups of a topic
2 participants