Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kafka properties to KafkaProtobufDeserializer. #1934

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

StephanePaulus
Copy link

Adding kafka properties to KafkaProtobufDeserializer, to be able to execute schema registry rules.

In class: AbstractKafkaSchemaSerDe, method protected Object executeRules, line 671

      RuleContext ctx = new RuleContext(config.originals(), source, target,
          subject, topic, headers,
          isKey ? original : key(),
          isKey ? null : original,
          isKey, ruleMode, rule, i, rules);

config.originals() will throw a null pointer exception and fail the deserialization.

Not sure if my fix is the best way, I guess maybe a method that takes all the kafka properties from both kafka and the schema registry including the URL and username/password with the default key that are defined in the connection configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant