Skip to content

Commit

Permalink
fix: exit on error for _execute_query worker
Browse files Browse the repository at this point in the history
  • Loading branch information
tconbeer committed Jan 26, 2024
1 parent 5a83faa commit 11ec222
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions src/harlequin/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,19 +382,6 @@ async def _handle_worker_error(self, message: Worker.StateChanged) -> None:
error=message.worker.error,
)
self.data_catalog.database_tree.loading = False
elif (
message.worker.name == "_execute_query" and message.worker.error is not None
):
self.run_query_bar.set_responsive()
self.results_viewer.show_table()
header = getattr(
message.worker.error, "title", message.worker.error.__class__.__name__
)
self._push_error_modal(
title="Query Error",
header=header,
error=message.worker.error,
)
elif message.worker.name == "_connect" and message.worker.error is not None:
title = getattr(
message.worker.error,
Expand Down Expand Up @@ -684,7 +671,7 @@ def _load_catalog_cache(self) -> None:
@work(
thread=True,
exclusive=True,
exit_on_error=False,
exit_on_error=True,
group="query_runners",
description="Executing queries.",
)
Expand Down

0 comments on commit 11ec222

Please sign in to comment.