Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add databricks adapter #433

Closed

Conversation

alexmalins
Copy link
Contributor

@alexmalins alexmalins commented Jan 29, 2024

WIP for when databricks adapter is released

cf. #374

@tconbeer
Copy link
Owner

@alexmalins when the package is ready on PyPI, you'll have to run poetry lock and then push the lockfile before we can merge this.

@alexmalins alexmalins force-pushed the add-support-databricks-adapter branch from 2985ae5 to f53ad02 Compare February 4, 2024 15:28
@alexmalins alexmalins marked this pull request as ready for review February 4, 2024 15:30
@alexmalins
Copy link
Contributor Author

Hey Ted! This one is good to go - we're live at https://pypi.org/project/harlequin-databricks/

@tconbeer
Copy link
Owner

tconbeer commented Feb 4, 2024

Woohoo!

@alexmalins
Copy link
Contributor Author

PR to add the adapter to conda-forge here

@tconbeer tconbeer linked an issue Feb 5, 2024 that may be closed by this pull request
@tconbeer
Copy link
Owner

tconbeer commented Feb 5, 2024

I'm trying to rebase this, and at least on my machine, Poetry can't seem to create a new lockfile (it just stalls). If you could try to rebase and re-run poetry lock, that would be great. Otherwise I'll come back to this shortly, after merging in some other updates

@tconbeer
Copy link
Owner

tconbeer commented Feb 5, 2024

spoke too soon -- just got it to work with poetry lock --no-update

@tconbeer
Copy link
Owner

tconbeer commented Feb 5, 2024

superseded by #449

@tconbeer tconbeer closed this Feb 5, 2024
@alexmalins alexmalins deleted the add-support-databricks-adapter branch February 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Databricks adapter
2 participants