Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Improved h2o-core dependency management in POM file. #1

Merged
merged 1 commit into from
Apr 8, 2014

Conversation

mmalohlava
Copy link
Contributor

H2O now uses maven dependency management to publish H2O artifacts into Sonatype repository.
So far we have no maven release, only publishing snapshots.

Hence I changed h2o-matrix project dependencies:

  • put proper dependency on h2o-core 2.5-SNAPSHOT
  • put additional test dependency on h2o-core (type:test-jar), since H2O core tests
    contain H2O test harness (class water.TestUtil)
  • removed dependency on water.TestUtil from project app code

Note: mvn test command still not working since H2O does not yet support
proper test execution via JUnitRunner (problem with classloading)

Changes in project dependencies:
- put proper dependency on h2o-core 2.5-SNAPSHOT
- put additional test dependency on h2o-core (type:test-jar), since H2O core tests
  contain H2O test harness (class water.TestUtil)
- removed dependency on water.TestUtil from project app code

Note: mvn test command still not working since H2O does not yet support
proper test execution via JUnitRunner (problem with classloading)
avati added a commit that referenced this pull request Apr 8, 2014
Improved h2o-core dependency management in POM file.
@avati avati merged commit 34ee5bd into tdunning:master Apr 8, 2014
@avati
Copy link
Collaborator

avati commented Apr 8, 2014

Michal,
The build (mvn compile) now fails with the following error:

[WARNING] The POM for ai.h2o:h2o-core:jar:2.5-SNAPSHOT is missing, no
dependency information available
[WARNING] The POM for ai.h2o:h2o-core:jar:tests:2.5-SNAPSHOT is
missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.465 s
[INFO] Finished at: 2014-04-08T13:20:19-08:00
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project h2o-matrix: Could not
resolve dependencies for project
h2o-matrix:h2o-matrix:jar:1.0-SNAPSHOT: The following artifacts could
not be resolved: ai.h2o:h2o-core:jar:2.5-SNAPSHOT,
ai.h2o:h2o-core:jar:tests:2.5-SNAPSHOT: Could not find artifact
ai.h2o:h2o-core:jar:2.5-SNAPSHOT -> [Help 1]

On Tue, Apr 8, 2014 at 1:01 PM, Michal Malohlava
[email protected]:

H2O now uses maven dependency management to publish H2O artifacts into
Sonatype repository.
So far we have no maven release, only publishing snapshots.

Hence I changed h2o-matrix project dependencies:

  • put proper dependency on h2o-core 2.5-SNAPSHOT
  • put additional test dependency on h2o-core (type:test-jar), since
    H2O core tests contain H2O test harness (class water.TestUtil)
  • removed dependency on water.TestUtil from project app code

Note: mvn test command still not working since H2O does not yet support

proper test execution via JUnitRunner (problem with classloading)

You can merge this Pull Request by running

git pull https://github.com/mmalohlava/h2o-matrix master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Improved h2o-core dependency management.

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/1
.

@mmalohlava
Copy link
Contributor Author

Ahh, sorry for that - I forgot to mention the right process:

  • if you have h2o project from github, you can publish h2o-core artifacts in you local maven cache by typing mvn clean install. This is useful during development if you need to change both projects. But in ideal case h2o-matrix should be developed against "stable H2O API".
  • if you have no h2o project, you can use Sonatype snapshot repository in you pom.xml - then you will force maven to fetch h2o-core-2.5-SNAPSHOT from this repo.
    • see my next pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants