Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LocalSheetID to pointer of int #839

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Sajito
Copy link
Contributor

@Sajito Sajito commented Feb 17, 2025

Sorry for creating as new PR, but it's still relevant. I can't reopen the closed pr.

Defined names can apply globally (i.e. for every sheet in the document). Global defined names have no LocalSheetID attached to them. LocalSheetID=0 means that the defined name only applies to the first sheet. By changing the type to *int the information will be preserved correctly.

Defined names can apply globally (i.e. for every sheet in the document).
Global defined names have no LocalSheetID attached to them.
LocalSheetID=0 means that the defined name only applies to the first sheet.
By changing the type to `*int` the information will be preserved correctly.
Copy link
Owner

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Sajito

@tealeg tealeg merged commit e96f423 into tealeg:master Feb 18, 2025
1 check passed
@Sajito Sajito deleted the fix/global-defined-names branch February 21, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants