Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#272 [FIX] collect 중복 호출 케이스 체크 #284

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

KkamSonLee
Copy link
Member

🎸 작업한 내용

  • 버튼 클릭 시 Collect 하는 로직들 제거
  • onSingleClickListener 달려있어서 중복 Collect는 웬만하면 생기지 않지만 네트워크 문제로 지연될 경우 중복 Collect가 생길수도 있기에 제거

🎶 PR Point

  • 담에 observe 중복 호출 케이스도 찾을게요

📸 스크린샷

없슴

💽 관련 이슈

@KkamSonLee KkamSonLee added 🐞FIX 버그 (버그 수정)시 사용합니다. 🪕민호🪕 민호가 연 pr, issue에 사용 labels Jul 16, 2023
@KkamSonLee KkamSonLee self-assigned this Jul 16, 2023
@@ -140,22 +157,6 @@ class LogInActivity : BaseActivity<ActivityLogInBinding>(ActivityLogInBinding::i
viewModel.fcmToken.value!!
)
viewModel.kakaoLogin(requestKakaoData)
collectFlowWhenStarted(viewModel.isExist){
Log.e("isExist", it.toString())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 만약에 null 이 떠서 아무 동작도 안하다가 다시 버튼 누르면 n개의 collect observer가 생김

@KkamSonLee KkamSonLee merged commit 38bb3c3 into develop Jul 17, 2023
1 check failed
@KkamSonLee KkamSonLee deleted the issue-#272 branch July 29, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞FIX 버그 (버그 수정)시 사용합니다. 🪕민호🪕 민호가 연 pr, issue에 사용
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] collect 중복 호출 케이스 체크
1 participant