#291 [FEAT] domain 모듈 코틀린 라이브러리로 변경 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KkamSonLee
commented
Jul 29, 2023
| @@ -5,7 +5,7 @@ import com.google.firebase.crashlytics.FirebaseCrashlytics | |||
| import com.kakao.sdk.common.KakaoSdk | |||
| import com.mument_android.BuildConfig | |||
| import com.mument_android.data.BuildConfig.KAKAO_NATIVE_KEY | |||
| import com.mument_android.domain.entity.musicdetail.musicdetaildata.Music | |||
| import com.mument_android.domain.entity.musicdetail.Music | |||
There was a problem hiding this comment.
depth 줄임 MusicDetailEntity 없애서 dicrectory가 하나 덜 필요해졌으
KkamSonLee
commented
Jul 29, 2023
| @@ -20,7 +19,7 @@ class MoveMusicDetailNavigatorProviderImpl @Inject constructor(private val activ | |||
| override fun intentMusicDetail(music: MusicInfoEntity) { | |||
| with(activity as SearchActivity) { | |||
| val intent = Intent(this, MainActivity::class.java).apply { | |||
| putExtra("MUSIC_INFO_ENTITY", music) | |||
| putExtra(MUSIC_INFO_ENTITY, music) | |||
KkamSonLee
commented
Jul 29, 2023
| inline fun <reified T : Serializable> Bundle.getBundleSerializable(key: String): T? = when { | ||
| SDK_INT >= TIRAMISU -> getSerializable(key, T::class.java) | ||
| else -> @Suppress("DEPRECATION") getSerializable(key) as? T | ||
| } |
KkamSonLee
commented
Jul 29, 2023
| @@ -2,5 +2,5 @@ package com.mument_android.data.dto.record | |||
|
|
|||
| data class MumentIsFirstDto( | |||
| val isFirst : Boolean, | |||
| val FirstAvaliable : Boolean | |||
| val firstAvailable : Boolean | |||
KkamSonLee
commented
Jul 29, 2023
| return if (it.data != null) { | ||
| setProfileMapper.map(it.data) | ||
| } else null | ||
| } |
There was a problem hiding this comment.
Multi Part 만드는 작업은 여기로 이관
KkamSonLee
commented
Jul 29, 2023
| addTestDependencies() | ||
| addNetworkDependencies() | ||
| addDaggerHiltDependencies() | ||
| implementation(KotlinDependencies.annotation) | ||
| implementation(KotlinDependencies.kotlinxSerialization) | ||
| implementation(KotlinDependencies.coroutines) | ||
| implementation(AndroidXDependencies.pagingCommon) |
There was a problem hiding this comment.
이거 안드로이드 의존성 아님, 테스트용 의존성
KkamSonLee
commented
Jul 29, 2023
| import android.widget.Toast | ||
| import java.io.ByteArrayOutputStream | ||
|
|
||
| private var toast: Toast? = null | ||
| fun Context.shortToast(text: String) { |
There was a problem hiding this comment.
이거 나중에 core-dependent 로 이동
KkamSonLee
commented
Jul 29, 2023
고생하셨습니당...!!ㅎㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 작업한 내용
🎶 PR Point
📸 스크린샷
💽 관련 이슈