Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two mild bugfixes #421

Open
wants to merge 3 commits into
base: 1.20.x
Choose a base branch
from
Open

Conversation

davidjjung
Copy link

@davidjjung davidjjung commented Aug 6, 2024

Fixed two bugs here as well:

  1. Removed a redundant axe stripping sound from WaxedPineconeBlock, as AxeItem already covers playing that sound depending on the inputted toolaction (and is still audible in testing, now at the same volume as when stripping normal logs)
  2. Allowed Potted Cartwheels to be rotated like their block suggests.
  • This one's might be a bit more controversial because vanilla lighting forces cartwheels to be a little more darkened in their east/west facing states. could possibly be improved with some culling stuff--I was never particularly good at block model management. That said, at least the functionality for cardinal cartwheel pot placement is now there 👍

And an accidental extra, because I didn't know git pushes on forks automatically add them to PR's retroactively 😓
3) Added forge:stripped_logs block tag. I wholly understand why this wouldn't be considered (as Forge did not include it in its own canon), but I guess it's here if it wants to see some use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant