Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfixes #204

Open
wants to merge 2 commits into
base: 1.20.x
Choose a base branch
from
Open

Minor bugfixes #204

wants to merge 2 commits into from

Conversation

davidjjung
Copy link

Very small changes for 1.20.1.

For the milk bottle change, the new implementation does make it that if one un-clearable status effect is targeted by the bottle, it simply won't clear any effects.

this is less than ideal, but the only alternative is to filter the list of active effects using that forge hook's push. implementing this would mean calling the hook multiple times, leading to the potential possibility of:

  1. I have three active effects: jump boost, simpering, and radioactivity
  2. there are event hooks attached to simpering and radioactivity: let's say that for simpering, on an attempt to remove, the player explodes instead. for radioactivity, the radioactivity level increases.
  3. the code tries to stream-filter the entity's active effects on milk bottle consumption. filtering using the forge hook triggers the player's explosion and radioactivity intensification. jump boost is successfully removed, but with two negative, unintended externalities

So that's why the current implementation is what it is. i hope it's acceptable--i still think it makes more sense than clearing that which should not be clearable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant