Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#318) - improve bar code recognition performance #319

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

๐Ÿ”€ :: (#318) - improve bar code recognition performance #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11028bd
:sparkles: :: Add scan stop logic after scanning qrcode
minStone-dev Oct 10, 2024
fbe2509
:sparkles: :: Qrcode scanner logic refactoring
minStone-dev Oct 10, 2024
ad1642f
Merge remote-tracking branch 'origin/develop' into develop
minStone-dev Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions feature/qrcode/src/main/java/com/goms/qrcode/component/QrcodeScanPreview.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,15 @@ internal fun QrcodeScanPreview(
)
.build()
.also {
it.setAnalyzer(cameraExecutor, QrcodeScanner { qrcodeData ->
if (isScanningEnabled) {
onQrcodeScan(qrcodeData)
isScanningEnabled = false
}
})
it.setAnalyzer(cameraExecutor, QrcodeScanner(
qrcodeData = { qrcodeData ->
if (isScanningEnabled) {
isScanningEnabled = false
onQrcodeScan(qrcodeData)
}
},
isScanningEnabled = { isScanningEnabled }
))
}

val cameraSelector = CameraSelector.DEFAULT_BACK_CAMERA
Expand Down
18 changes: 12 additions & 6 deletions feature/qrcode/src/main/java/com/goms/qrcode/util/QrcodeScanner.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import com.google.mlkit.vision.barcode.common.Barcode
import com.google.mlkit.vision.common.InputImage

class QrcodeScanner(
val qrcodeData: (String?) -> Unit
val qrcodeData: (String?) -> Unit,
val isScanningEnabled: () -> Boolean
) : ImageAnalysis.Analyzer {

private val scanner = BarcodeScanning.getClient(
Expand All @@ -19,18 +20,23 @@ class QrcodeScanner(
)
@androidx.annotation.OptIn(androidx.camera.core.ExperimentalGetImage::class)
override fun analyze(imageProxy: ImageProxy) {
if (!isScanningEnabled()) {
imageProxy.close()
return
}

val mediaImage = imageProxy.image
mediaImage?.let {
val image = InputImage.fromMediaImage(mediaImage, imageProxy.imageInfo.rotationDegrees)

scanner.process(image)
.addOnSuccessListener { barcodes ->
val qrCodeValues = mutableListOf<String>()
for (barcode in barcodes) {
barcode.displayValue?.let { qrCodeValues.add(it) }
}
if (qrCodeValues.isNotEmpty()) {
qrcodeData(qrCodeValues.joinToString(", "))
Log.d("qrcode","ing..")
barcode.displayValue?.let {
Log.d("qrcode",it)
if (it != null) qrcodeData(it)
}
}
}
.addOnFailureListener {
Expand Down
Loading