Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.0.0 Add Typescript support #185

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

V2.0.0 Add Typescript support #185

wants to merge 77 commits into from
+108,530 −22,393

Conversation

lucasassisrosa
Copy link
Contributor

@lucasassisrosa lucasassisrosa commented Sep 24, 2024 •
edited
Loading

Addresses #32

This PR will remain open while v2.0.0 is in alpha

I have labeled some files as important for check when reviewing. Please use the file filter to omit the "excluded files" when reviewing.

  • resources
  • tests
  • base files

Manual testing

  • Check README instructions on testing and typescript
  • Run npm run lint
  • Run npm run build
    • Check output in dist folder
  • Check types in types folder
  • Run npm run test
  • to run a SDK usage examples:
    • in the root dir, run npm link
    • go to examples/call-control or examples/messaging
    • run npm link telnyx
    • run export TELNYX_API_KEY=` (this should use PROD API Key)
    • run npm run start

@lucasassisrosa
DOTCOM-3581: update deps and add typescript default config (#177)
fa89888 
* update deps and add typescript default config

* update prettier config
@lucasassisrosa
DOTCOM-3583: convert base files to typescript (#179)
30c9792 
* update deps and add typescript default config

* convert Telnyx main to typescript

* bump version to v2 alpha

* update changelog

* convert Error and Telnyx method to typescript

* update utils

* convert autoPagination, makeRequest, TelnyxMethod and Webhooks

* convert TelnyxResource

* remove extra lint file

* add types folder

* update code comments on framework naming

* specify error types

* update eslint rules

* add types generated from openapi specs

* add TelnyxIncomingHttpHeaders type

* add BalanceResource type defs
@lucasassisrosa
DOTCOM-3584: convert resource files and tests to typescript (#181)
4c45b92 
* update deps and add typescript default config

* convert Telnyx main to typescript

* bump version to v2 alpha

* update changelog

* convert Error and Telnyx method to typescript

* update utils

* convert autoPagination, makeRequest, TelnyxMethod and Webhooks

* convert TelnyxResource

* remove extra lint file

* add types folder

* update code comments on framework naming

* specify error types

* update eslint rules

* add types generated from openapi specs

* add TelnyxIncomingHttpHeaders type

* add BalanceResource type defs

* convert resource files and tests to typescript

* update overall test setup

* add autoPagination, telnyx, utils and Balance specs

* add Webhooks tests

* add autoPagination, telnyx.node, TelnyxResource, Webhooks and utils test

* add MessagingProfiles resource

* remove stale coverage report on README
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 24, 2024
View reviewed changes
src/utils.ts Dismissed Show dismissed Hide dismissed
src/utils.ts Dismissed Show dismissed Hide dismissed
lucasassisrosa
lucasassisrosa commented Sep 24, 2024
View reviewed changes
types/TelnyxAPI.d.ts Outdated Show resolved Hide resolved
@lucasassisrosa lucasassisrosa added the help wanted Extra attention is needed label Sep 25, 2024
lucasassisrosa
lucasassisrosa commented Sep 25, 2024
View reviewed changes
CHANGELOG.md
##
## v2

### v2.0.0-alpha.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

important

lucasassisrosa
lucasassisrosa commented Sep 25, 2024
View reviewed changes
types/TelnyxAPI.d.ts Outdated Show resolved Hide resolved
lucasassisrosa
lucasassisrosa commented Sep 25, 2024
View reviewed changes
types/index.d.ts Outdated Show resolved Hide resolved
@lucasassisrosa
Copy link
Contributor Author

addresses:

@lucasassisrosa
Copy link
Contributor Author

PR check failed cause /number_order_documents endpoints were removed. I'm removing these endpoints from SDK to match

ADandyGuyInSpace
ADandyGuyInSpace approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@ADandyGuyInSpace ADandyGuyInSpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tests passing and we are much improved/

@lucasassisrosa
Copy link
Contributor Author

Beta 5 to fix #191 and #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BueTelnyx BueTelnyx BueTelnyx approved these changes

@ADandyGuyInSpace ADandyGuyInSpace ADandyGuyInSpace approved these changes

@jonathan-telnyx jonathan-telnyx jonathan-telnyx approved these changes

@DRS90 DRS90 DRS90 approved these changes

@chasenpse chasenpse chasenpse approved these changes

@dmmc12 dmmc12 Awaiting requested review from dmmc12

@DeividVeloso DeividVeloso Awaiting requested review from DeividVeloso

@enzoqtvf enzoqtvf Awaiting requested review from enzoqtvf

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lucasassisrosa @chasenpse @DRS90 @jonathan-telnyx @ADandyGuyInSpace @BueTelnyx @mpareja-godaddy