Is/feature/custom headers #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post Custom Headers from INVITE Messages Add Custom Headers to ANSWER Messages Post Custom Headers from ANSWER Messages
Conflicts: TelnyxRTC.xcodeproj/project.pbxproj TelnyxRTC/Telnyx/TxClient.swift TelnyxRTC/Telnyx/WebRTC/Call.swift TelnyxWebRTCDemo/Extensions/ViewControllerVoIPExtension.swift
RJSkorski
approved these changes
Oct 25, 2023
TelnyxRTC/Telnyx/WebRTC/Call.swift
Outdated
| @@ -213,14 +220,14 @@ public class Call { | |||
| It sets the incoming sdp as the remoteDecription. | |||
| sdp: Is the remote SDP to configure in the current RTCPeerConnection | |||
| */ | |||
| private func answered(sdp: String) { | |||
| private func answered(sdp: String,custumHeaders:[String:String] = [:]) { | |||
TelnyxRTC/Telnyx/TxClient.swift
Outdated
|
|
||
| let currentRoute = AVAudioSession.sharedInstance().currentRoute | ||
|
|
||
| func isSppeakerEnabled() -> Bool { |
There was a problem hiding this comment.
misspelling: double p in speaker
RJSkorski
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEBRTC-4632 - Ticket title
Passing and Accepting Custom Headers
passing custom headers from SIP INVITE to RTC INVITE (session_id=dcc9f896-6821-11ee-9e86-02420a0d3a69):
passing custom headers from RTC INVITE to SIP INVITE (session_id=cc59cbec-6823-11ee-acca-02420a0d6669)
it works.
passing custom headers from answer RTC message on SIP responses (session_id=3e734902-6823-11ee-895c-02420a0d3a69)
After changes
Custom headers are passed for INVITE and ANSWER Messages
TODO
Complete Tutorial Docs.
✋ Manual testing
All call functionality works