Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiples calls (End and Accept/Decline) #115

Merged
merged 9 commits into from
Feb 15, 2024

Conversation

isaacakakpo1
Copy link
Contributor

The change is to help implement handling multiples on the client side.
A change was made to the telnyx client to remove disconnecting from socket when handling push notifications.

👴 👶 Behaviors

Before changes

  • Only one Active call.

After changes

  • Multiple calls can be handled

TODO

Support call holding

README.md Outdated
}

```
Subsequently, when the user clicks on the End and Accept or Decline Button, you will need to determine which og these buttons was clicked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

og -> of

README.md Outdated
To handle multiples, we can rely on the `CXProviderDelegate` delegate which invokes functions corresponding to
what action was performed on the callkit user interface.

1. End and Accept or Decline : The **end and accept** button on the callkit user interface accepts the nwe call and ends the previous call.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nwe -> new

README.md Outdated

1. End and Accept or Decline : The **end and accept** button on the callkit user interface accepts the nwe call and ends the previous call.
Callkit then invokes the `CXAnswerCallAction` and `CXEndCallAction` when the **end and accept** button is pressed.
You can handle this scenario by :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the space before :

Copy link

@imranbilal1 imranbilal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it. Just minor typos.

@isaacakakpo1 isaacakakpo1 merged commit 1ddc84c into main Feb 15, 2024
1 check passed
@isaacakakpo1 isaacakakpo1 deleted the IS/feature/MultipleCalls branch February 26, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants