[WEBRTC-2347] [feat] Stats #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages as part of the data payload. Test sending stats on ice candidates event
…s to handle the stats logic
… 'debug' property on TxClient to enable / disable webrtc stats tracking
isaacakakpo1
previously approved these changes
Nov 29, 2024
…rt to a dictionary required by the stats messages
…on to reduce duplication
Send a start message before initializing the peer connection to avoid losing peer events. The correct message sequence is: 1. Start message before creating the peer connection. 2. Add connection message after the peer connection is created. 3. Subscribe to all RTCPeerConnection events.
# Conflicts: # TelnyxRTC/Telnyx/WebRTC/Peer.swift
Oliver-Zimmerman
requested changes
Jan 8, 2025
Oliver-Zimmerman
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEBRTC-2347 [feat] WebRTC Stats
Add WebRTCStatsReporter and Enhance Peer Connection Event Handling
Summary:
This PR introduces significant improvements to the WebRTC integration, including a new WebRTCStatsReporter class, a debug property for enabling/disabling statistics monitoring, and enhanced event handling via the WebRTCEventHandler protocol.
Key Changes:
WebRTCStatsReporter:
Periodically collects WebRTC statistics, including audio streams and connection candidates.
Sends these statistics to the server via a socket using a specific structured format.
Adds support for extracting detailed connection information, such as the selected candidate pair.
Debugging Property:
Introduces a debug property in TxConfig to enable or disable the monitoring of WebRTC statistics.
The property defaults to false, ensuring performance optimization unless debugging is explicitly required.
Enhanced Event Handling:
Implements WebRTCEventHandler to standardize handling key WebRTC events, such as signaling state changes, ICE candidate updates, and data channel events.
Adds detailed debug messages for event logging and diagnostics.