Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [WEBRTC-2412] Project workspace #147

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

gbattistel
Copy link
Collaborator

@gbattistel gbattistel commented Jan 10, 2025

WEBRTC-2412 Project workspace

Describe your change here

This PR addresses an issue with the demo app where the following error occurred while attempting to archive the app:

Multiple commands produce '..../TelnyxRTC.framework'

The following changes were made to resolve this issue:

  • Removed remnants of the unused GoogleWebRTC library.
  • Removed the Pods framework from the demo app to fix the archive issue.
  • Updated app version to 0.1.22

👴 👶 Behaviors

Before changes

  • The demo app would fail to archive due to multiple conflicting framework targets.
  • GoogleWebRTC library and external dependencies were still referenced but were not in use.

After changes

  • The archiving issue has been resolved, and the demo app can now be archived successfully.
  • The unused GoogleWebRTC library has been completely removed.
  • The removal of unnecessary Pods framework from the demo app has resolved the build conflict.

✋ Manual testing

  1. Clone the repository.
  2. Run pod install
  3. Open the Xcode worskpace (TelnyxRTC.xcworskpace).
  4. Clean the build folder (Cmd + Shift + K).
  5. Try archiving the demo app (Cmd + Shift + B).
  6. Ensure that no errors occur during the archiving process.
  7. Run the demo app in Debug mode and verify that the app functions correctly.

@gbattistel gbattistel changed the title Fix/webrtc 2412 workspace [FIX] [WEBRTC-2412] Project workspace Jan 10, 2025
Copy link

@Oliver-Zimmerman Oliver-Zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From following the steps it works as expected

@gbattistel gbattistel merged commit cfdbf16 into main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants