Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(graphql): upgrade graphql to v16 and apollo-server to v4 #8753

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

luvkapur
Copy link
Member

@luvkapur luvkapur commented Apr 5, 2024

This PR updates the graphql and apollo-server version to the latest.
One of the key update is dropping the dependency on subscription-transport-ws to implement websockets and graphql subscriptions. subscription-transport-ws is not maintained and has numerous security issues. We replace subscription-transport-ws with the graphql-ws which is the recommended lib to implement web sockets and graphql subscriptions.

This PR also fixes subscriptions in the workspace. Previously, even though the schema had subscriptions defined for component updates in the workspace, it wasn't implemented correctly which resulted in the client never receiving any live updates from the server. With this fix, now the client receives live updates from the workspace regarding component updates (additions, modifications, deletions)

Workspace Live Updates
Screen Recording 2024-04-16 at 9 47 53 AM

Apollo 4 Playground
image

workspace.jsonc Outdated Show resolved Hide resolved
@luvkapur luvkapur changed the title chore(graphql): upgrade graphql to v16 and apollo-server to v4 infra(graphql): upgrade graphql to v16 and apollo-server to v4 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants