fix: webhooks missing triggers and events #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfleischmann
requested review from
bjoern-m and
FreddyDevelop
and removed request for
bjoern-m
|
Should the backend README and hanko.config.json files be updated to include these new webhook events? |
Yeah, I updated the events table in the README, thanks. As for the schema: left it out deliberately this time to be honest because we currently have a CI workflow that watches for config changes, regenerates the schema and makes a PR (the use case being precisely the case of someone forgetting to regenerate the schema). Would not have hurt to do it manually though - the workflow wouldn't/shouldn't make a PR in that case. |
bjoern-m
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2009