Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use exact template names for email.send webhook types #2037

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: use exact template names for email.send webhook types #2037

wants to merge 3 commits into from

Conversation

lfleischmann
Copy link
Member

@lfleischmann lfleischmann commented Jan 29, 2025 •
edited
Loading

Description

Each email template should have its own type value in the email.send webhook payload.

Implementation

  • Remove EmailType string alias for webhhok.EmailSend.Type field
  • Directly use mail template names as the value for webhhok.EmailSend.Type field

@lfleischmann lfleischmann marked this pull request as ready for review January 29, 2025 00:11
@lfleischmann lfleischmann changed the title feat: add more webhook email types feat: use exact template names for email.send webhook types Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoern-m bjoern-m Awaiting requested review from bjoern-m

@FreddyDevelop FreddyDevelop Awaiting requested review from FreddyDevelop

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hanko
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lfleischmann