Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transactions): add transaction api #24

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Conversation

shentschel
Copy link
Collaborator

@shentschel shentschel commented Nov 24, 2023

Transactions are hashed with SHA256 and appended
to the challenge.

A Transaction contains an identifier and a data block. The datablock will be transformed to a json string before storing and hashing.

Also does:

  • add API endpoints for transactions
  • extend audit log with transaction identifier
  • add migrations/models and persister for transactions
  • audit log is now initialized with tenant and context from middlware to reduce params in Create and CreateWithConnection calls
  • No relation between audit logs and transaction to prevent mutation of audit log entries
  • adds expire date to jwts
  • add specific token for transactions which also contains transaction identifier

Closes: #23
Fix: #21

Transactions are hashed with SHA256 and appended
to the challenge.

A Transaction contains an identifier and a data block. The datablock will be transformed to a json string before storing and hashing.

Also does:

* add API endpoints for transactions
* extend audit log with transaction identifier
* add migrations/models and persister for transactions
* audit log is now initialized with tenant and context from middlware to reduce params in Create and CreateWithConnection calls
* No relation between audit logs and transaction to prevent mutation of audit log entries

Closes: #23
@shentschel shentschel self-assigned this Nov 24, 2023
Stefan Jacobi added 2 commits November 24, 2023 13:35
* adds expire date to jwts
* add specific token for transactions which also contains transaction identifier

Closes: #23
Fixes: #21
server/api/handler/login.go Outdated Show resolved Hide resolved
server/api/handler/transaction.go Outdated Show resolved Hide resolved
server/api/dto/request/requests.go Outdated Show resolved Hide resolved
server/api/handler/transaction.go Outdated Show resolved Hide resolved
spec/passkey-server.yaml Outdated Show resolved Hide resolved
spec/passkey-server.yaml Outdated Show resolved Hide resolved
Stefan Jacobi added 2 commits November 28, 2023 16:22
* add missing length validators and constraints to requests and spec
* add transaction operation
* moved userHandle function to webauthn handler
* add missing error in login finish
* improve check for DisplayName on registration

#Related to #24
@shentschel shentschel merged commit ce7b848 into main Nov 29, 2023
4 checks passed
@shentschel shentschel deleted the feat/transactions-api branch November 29, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction API JWT needs an expiry date
2 participants