[update] allow php version 8.3

.github/workflows/qa.yaml

@@ -22,7 +22,7 @@ jobs:
       - name: PHP Setup
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.2
+          php-version: 8.3
 
       - name: Validate composer.json
         run: composer validate --strict

.github/workflows/tests.yaml

@@ -25,6 +25,8 @@ jobs:
             dependencies: "highest" # Pimcore 11.*
           - php-version: "8.2"
             dependencies: "highest" # Pimcore 11.*
+          - php-version: "8.3"
+            dependencies: "highest" # Pimcore 11.*
 
     steps:
       - name: Git Checkout

compose.yaml

@@ -1,6 +1,6 @@
 services:
   database:
-    image: mariadb:10.11.4
+    image: mariadb:10.11.10
     command: ["mysqld", "--character-set-server=utf8mb4", "--collation-server=utf8mb4_unicode_ci"]
     environment:
       MYSQL_ALLOW_EMPTY_PASSWORD: yes
@@ -16,11 +16,11 @@ services:
       timeout: 10s
 
   php:
-    image: pimcore/pimcore:php8.2-latest
+    image: pimcore/pimcore:php8.3-latest
     volumes:
       - ./:/var/www/html/
     environment:
-      MYSQL_SERVER_VERSION: mariadb-10.11.4
+      MYSQL_SERVER_VERSION: 10.11.10-MariaDB
     depends_on:
       database:
         condition: service_healthy

composer.json

@@ -18,7 +18,7 @@
     }
   },
   "require": {
-    "php": "~8.1.0 || ~8.2.0",
+    "php": "~8.1.0 || ~8.2.0 || ~8.3.0",
     "pimcore/pimcore": "^10.5 || ^11.0",
     "symfony/config": "^5.3 || ^6.0",
     "symfony/console": "^5.3 || ^6.0",
@@ -36,7 +36,7 @@
     "phpstan/phpstan-phpunit": "^1.1",
     "phpstan/phpstan-symfony": "^1.2",
     "phpunit/phpunit": "^9.5",
-    "teamneusta/pimcore-testing-framework": "^0.11.0"
+    "teamneusta/pimcore-testing-framework": "^0.12.0"
   },
   "conflict": {
     "presta/sitemap-bundle": "<3.1",

phpstan.neon

@@ -7,5 +7,3 @@ parameters:
 
 	bootstrapFiles:
 		- vendor/pimcore/pimcore/stubs/dynamic-constants.php
-
-	checkGenericClassInNonGenericObjectType: false

src/Controller/PresentationController.php

@@ -4,6 +4,7 @@
 
 use Neusta\Pimcore\PresentationBundle\Renderer\PresentationRenderer;
 use Pimcore\Controller\FrontendController;
+use Pimcore\Model\Document\PageSnippet;
 use Symfony\Component\HttpFoundation\Response;
 
 class PresentationController extends FrontendController
@@ -14,8 +15,13 @@ public function __construct(private readonly PresentationRenderer $presentationR
 
     public function presentationAction(): Response
     {
+        $slidesMarkup = '';
+        if ($this->document instanceof PageSnippet) {
+            $slidesMarkup = $this->presentationRenderer->renderPresentation($this->document);
+        }
+
         return $this->render('@NeustaPimcorePresentation/Presentation/presentation.html.twig', [
-            'slidesMarkup' => $this->presentationRenderer->renderPresentation($this->document),
+            'slidesMarkup' => $slidesMarkup,
         ]);
     }
 }

tests/Twig/PresentationExtensionTest.php

@@ -55,7 +55,7 @@ public function getThemeReturnsThemeOfParentDocumentIfAvailable(): void
         self::assertSame('theme filename of parent document', $presentationExtension->getThemeFile($context));
     }
 
-    private function createDocumentWithEditableMock(?Document\Editable $themeEditable, Document\PageSnippet $parent = null): Document\PageSnippet
+    private function createDocumentWithEditableMock(?Document\Editable $themeEditable, ?Document\PageSnippet $parent = null): Document\PageSnippet
     {
         $document = $this->prophesize(Document\PageSnippet::class);
         $document