Skip to content

Commit

Permalink
Merge pull request #194 from teamterning/develop
Browse files Browse the repository at this point in the history
[🔀 merge] [3차] 코드 리펙토링 사항 적용
  • Loading branch information
junggyo1020 authored Jan 12, 2025
2 parents 1d121ab + fa4a561 commit a4ade93
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ dependencies {
implementation 'io.jsonwebtoken:jjwt-api:0.11.5'
implementation 'io.jsonwebtoken:jjwt-impl:0.11.5'
implementation 'io.jsonwebtoken:jjwt-jackson:0.11.5'
implementation 'com.nimbusds:nimbus-jose-jwt:3.10'
// implementation 'com.nimbusds:nimbus-jose-jwt:3.10'

// Gson
implementation 'com.google.code.gson:gson:2.8.6'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,15 @@ public Page<Tuple> findFilteredInternshipsWithScrapInfo(User user, String sortBy
}

private BooleanExpression getGraduatingFilter(User user){
if(user.getFilter().getGrade() != Grade.SENIOR){
return internshipAnnouncement.isGraduating.isFalse();
if(user.getFilter().getGrade() == null) return null;
if(user.getFilter().getGrade() == Grade.SENIOR){
return internshipAnnouncement.isGraduating.isTrue();
}
return null;
return internshipAnnouncement.isGraduating.isFalse();
}

private BooleanExpression getWorkingPeriodFilter(User user){
if(user.getFilter().getWorkingPeriod() == null) return null;
if(user.getFilter().getWorkingPeriod() == WorkingPeriod.OPTION1){
return getWorkingPeriodAsNumber().between(1,3);
} else if(user.getFilter().getWorkingPeriod() == WorkingPeriod.OPTION2){
Expand All @@ -183,6 +185,8 @@ private BooleanExpression getWorkingPeriodFilter(User user){
private BooleanExpression getStartDateFilter(User user){
int startYear = user.getFilter().getStartYear();
int startMonth = user.getFilter().getStartMonth();

if(startYear == 0 || startMonth == 0) return null;
return internshipAnnouncement.startYear.eq(startYear)
.and(internshipAnnouncement.startMonth.eq(startMonth));
}
Expand Down Expand Up @@ -238,7 +242,7 @@ private NumberTemplate<Integer> sortAnnouncementsByDeadline() {
}

private BooleanExpression getJobTypeFilter(User user) {
if (user.getFilter().getJobType() == JobType.TOTAL) {
if (user.getFilter().getJobType() == null || user.getFilter().getJobType() == JobType.TOTAL) {
return null; // total일 경우 모든 직무 공고 허용
}
return internshipAnnouncement.jobType.eq(user.getFilter().getJobType().getValue());
Expand Down

0 comments on commit a4ade93

Please sign in to comment.