-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[π merge] [3μ°¨] μ½λ 리νν λ§ μ¬ν μ μ© (3) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jsoonworld
commented
Dec 21, 2024
- [π merge] [3μ°¨] μ€νλ¦°νΈ μ½λ 리νν λ§ μ¬νμ μ μ©ν©λλ€.
- InternshipRepositoryμ findFilteredInternshipsWithScrapInfo λ©μλ μΆκ°νμ¬ QueryDSL κΈ°λ°μΌλ‘ μ€ν¬λ© μ 보μ ν¨κ» κ³΅κ³ λ°μ΄ν°λ₯Ό μ‘°ν. - HomeServiceImplμμ κΈ°μ‘΄ μ€ν¬λ© μ 보 λ‘μ§μ μ κ±°νκ³ , μλ‘ μΆκ°λ ν΅ν© λ©μλλ‘ λ체. - HomeService μ±λ₯ ν μ€νΈ μΆκ°νμ¬ λ€μν 쑰건μμ μ±λ₯ νμΈ: - 1κ°, 100κ°, 1000κ°μ κ³΅κ³ λ°μ΄ν°λ₯Ό κΈ°λ°μΌλ‘ μλ΅ μκ° μΈ‘μ . - DTO 맀ν λ‘μ§μ κ°μννκ³ , isScrapped λ‘μ§μ λ³λ λ©μλλ‘ μΆμΆνμ¬ κ°λ μ± κ°μ .
[β»οΈ refactor/#173]: updateUserFilter λ©μλ 리ν©ν λ§
- λ³κ²½ μ /νμ query λ‘μ§μ λν λΆνν μ€νΈλ₯Ό μ§ννκΈ° μν΄ JMeter νμ©νμ΅λλ€. - λνμ μΈ λκ΅¬μΈ k6, nGrinder, JMeter μ€ JMeterλ₯Ό μ νν μ΄μ λ HTML νμμ λ³΄κ³ μκ° μ μ 리λμ΄ μκ³ , λ νΌλ°μ€μ κ·λͺ¨μ μ¬μ©μ± μΈ‘λ©΄μ κ³ λ €νμ΅λλ€.
- Scrap μ 보λ₯Ό ν λ²μ μ‘°ν νλλ‘ λ³κ²½ (QueryDSL Tuple νμ©) - Enum Colorμ λ΄λΆ λ©μλλ₯Ό νμ©ν΄μ μμκ°μ λΆλ¬μ€λλ‘ μμ - λΆνμν λ©μλλ₯Ό μ κ±°νκ³ , isScrapped λ‘μ§μ μ’ λ λ¨μνκ² μμ
[β»οΈ refactor/#175]: κ³΅κ³ λ°μ΄ν° μ‘°ν μ±λ₯ μ΅μ ν λ° N+1 λ¬Έμ ν΄κ²°
[β»οΈ refactor] N+1 λ¬Έμ ν΄κ²° λ° HomeServiceImpl μ±λ₯ κ°μ
- ν - λ± λ§λ λνμ μΈν΄ κ³΅κ³ API μμ Query Parameterλ‘ μ λ¬λλ year, monthλ₯Ό μμ νκ³ , μ¬μ©μμ νν°λ§ μ 보λ₯Ό μ΄μ©ν΄ κ³΅κ³ λ€μ νν°λ§νμ¬ μ λ¬ν μ μλλ‘ λ‘μ§μ μμ νμ΅λλ€.
[β»οΈ refactor/#179] λμκ² λ± λ§λ λνμ μΈν΄ κ³΅κ³ API Query Parameter μ¬μ‘°μ
[π merge] [3μ°¨] μ½λ 리νν λ§ μ¬ν μ μ©
- μ¬μ©μμ μ§λ¬΄ νν°λ§(jobType)κ³Ό κ³ν νν°λ§ μ¬νμ λͺ¨λ νλ²μ μμ νλ νν°λ§ μ μ€μ APIμ νν°λ§ μ 보λ₯Ό λΆλ¬μ€λ APIλ₯Ό ꡬνν©λλ€.
[β¨ feat] μ§λ¬΄νν°λ§, μ¬μ©μ νν°λ§ μ 보, νν°λ§ μ¬μ€μ (μ§λ¬΄, κ³ν) API ꡬν
[π merge] [3μ°¨] μ½λ 리νν λ§ μ¬ν μ μ© (2)
- κ³΅κ³ μ‘°ν APIμ νμ΄μ§ κΈ°λ₯ μΆκ° - Pageableμ νμ©ν νμ΄μ§ μ²λ¦¬ ꡬν - `@PageableDefault`λ₯Ό ν΅ν΄ κΈ°λ³Έ νμ΄μ§ ν¬κΈ° μ€μ - DTO μμ - HomeAnnouncementsResponseDtoμ νμ΄μ§ κ΄λ ¨ νλ μΆκ° (`totalPages`, `hasNext`) - Repository μμ - νμ΄μ§ μ²λ¦¬λ κ³΅κ³ λ°μ΄ν°λ₯Ό λ°ννλλ‘ μΏΌλ¦¬ μμ - `Page<Tuple>`λ₯Ό νμ©ν νμ΄μ§ λ‘μ§ κ΅¬ν - Service λ‘μ§ λ¦¬ν©ν λ§ - κ³΅ν΅ λ©μλ λΆλ¦¬ (`getUserById`, `createEmptyResponse` λ±) - Color κ° λ° μ€ν¬λ© μ¬λΆ μ²λ¦¬ λ©μλ λΆλ¦¬ (`isScrapped`, `determineColorValue`) - Swagger μμ - API λ¬Έμμ νμ΄μ§ νλΌλ―Έν° λ°μ
[β¨feat/#185]: κ³΅κ³ μ‘°ν νμ΄μ§λ€μ΄μ κΈ°λ₯ λμ λ° μλΉμ€ λ‘μ§ κ°μ
[π merge] [3μ°¨] μ½λ 리νν λ§ μ¬ν μ μ© (3)
- μ¨λ³΄λ© 건λλ°κΈ° μ, ν΄λΌμμ nullκ°μ λ°μμ¬ μ μλλ‘ APIλ₯Ό μμ νμ΅λλ€
[π₯ !hotfix] μ§λ¬΄νν°λ§, μ¬μ©μ νν°λ§ μ 보, νν°λ§ μ¬μ€μ (μ§λ¬΄, κ³ν) API μμ
[π₯ !hotfix] νν°λ§ μ λ³΄κ° λͺ¨λ nullμ΄λ©΄ μ 체 κ³΅κ³ κ° λ³΄μ΄λλ‘ μμ
[π merge] [3μ°¨] μ½λ 리νν λ§ μ¬ν μ μ©
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.