-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for reading model-to-image transformation information. #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the PR - looks great to me, let's get it in
assert model.minx.cscale == pytest.approx((10.680000, 10.680000, 10.680000), abs=1e-6) | ||
assert model.minx.ctrans == pytest.approx((-2228.0, 2228.0, 681.099976), abs=1e-6) | ||
assert model.minx.crot == pytest.approx((0.0, 0.0, 0.0), abs=1e-6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh didn't know about pytest.approx
- snazzy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, pretty useful for any tests involving any type of computation or parsing!
Assuming you want to push a release, you've got maintainer access so it should be as easy as git checkout main
git tag -a v0.0.14 -m "v0.0.14"
git push --follow-tags upstream/main Let me know if you run into any issues, thanks!! |
For some reason that last command does not seem to work for me. Are you calling these commands on a fork of this repo or on this repo itself? Do you have to set this one as an additional remote? Fails with
|
This repo (teamtomo/imodmodel) is set as the remote named 'upstream' - are your ssh keys set up for this GitHub account? |
Yes, all of that is set up, but I figured it out, it should be
space instead of slash. This auto-release setup is cool though, I shall copy it for my own packages. |
@uermel sorry my bad - I recommend starting projects from the copier template here to auto set up all of this :-) https://pydev-guide.github.io/quickstart/ |
IMOD stores model-to-image transforms in an optional chunk called
MINX
with the below contents:See also: imod binspec
This PR adds support for parsing the
MINX
chunk using the model based API and stores it in a field calledminx
in the parsedImodModel
. Also adds a test for parsing.