Added support for individual point sizes (radii) #28
Conversation
vschwarze
changed the title
There was a problem hiding this comment.
Great work here @vschwarze !
- I like that the models in models.py mirror the binary spec and
PointSizeis a departure from this -> given that it has only a single field let's remove that class - the name
psizesdoesn't mirror anything in the binary spec so let's simply call itpoint_sizesand make it a numpy array - could you add tests covering the new functionality?
Once these changes are done we can merge here and cut a release 🙂
|
@vschwarze as an aside - a bunch of us who contribute to these packages have a zulip channel for chatting and meet 4 times a year to discuss what we're working on. If you're interested in being involved please join over at https://imagesc.zulipchat.com/#narrow/channel/426493-TeamTomo and write a quick message introducing yourself :-) |
Co-authored-by: alisterburt <[email protected]>
Co-authored-by: alisterburt <[email protected]>
Co-authored-by: alisterburt <[email protected]>
Co-authored-by: alisterburt <[email protected]>
Co-authored-by: alisterburt <[email protected]>
|
Hi @alisterburt, I implemented your suggestions and added some basic tests and provided a test file. And I will have a look at your zulip channel. |
3 similar comments
|
Hi @alisterburt, I implemented your suggestions and added some basic tests and provided a test file. And I will have a look at your zulip channel. |
|
Hi @alisterburt, I implemented your suggestions and added some basic tests and provided a test file. And I will have a look at your zulip channel. |
|
Hi @alisterburt, I implemented your suggestions and added some basic tests and provided a test file. And I will have a look at your zulip channel. |
|
@vschwarze congratulations on your first PR! 🥳 Great work and thanks for taking the time I'll push this out as imodmodel v0.0.15 now |
|
v0.0.15 will be on PyPI once this has finished https://github.com/teamtomo/imodmodel/actions/runs/13058463816 |
Added the support to read and write individual point sizes. They are stored as an array inside a
PointSizeobject that can be found inside theContourobjects. Indices of the point size array correspond with the indices of the point coordinates. Point sizes are stored in pixel coordinates.