Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backup file #58

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Update backup file #58

merged 3 commits into from
Apr 29, 2024

Conversation

hanjinliu
Copy link
Collaborator

Creating backup files calls rename method, but this method fails if the new path already exists.
I don't know if this is the intended behavior, but I guess the old backup file should be updated.

This PR adds a piece of lines so that the old backup file will be removed before renaming.

Copy link
Collaborator

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks @hanjinliu !

By the way - we are in the process of formalising what this teamtomo project is/does as a group on the imagesc zulip. It would be great to have you be involved and join the discussions!

https://imagesc.zulipchat.com/#narrow/stream/426493-TeamTomo

@alisterburt
Copy link
Collaborator

just waiting on CI

@hanjinliu
Copy link
Collaborator Author

Hi @alisterburt , thank you for sharing the zulip link! That'll be very helpful!

@alisterburt alisterburt merged commit 0606cf4 into teamtomo:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants