Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDERCMS-232: Add Lely fonts and styles #173

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

dmorbitzer
Copy link
Contributor

Copy link

aem-code-sync bot commented Oct 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 16, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fonts sind doppelt drin

}

@font-face {
font-family: roboto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warum roboto?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wollen wir wirklich die styles.css überschreiben. würde ich gerne vermeiden

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin offen für Vorschläge wie ich einzelne Inhalte überschreiben kann

@aem-code-sync aem-code-sync bot temporarily deployed to feature/edercms-232 October 21, 2024 06:56 Inactive
styles/theme.css Outdated
@@ -35,4 +35,42 @@
--button-background: var(--color-gray-darker);
--button-background-hover: var(--color-white);
--button-border: var(--color-gray-darker);

/* font vars */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kann man das nicht in eine font-variables.css oder so hauen? dann müsste man diese nur bei lely abändern

@sippsolutions sippsolutions merged commit 5a5db5c into main Oct 22, 2024
3 checks passed
@sippsolutions sippsolutions deleted the feature/edercms-232 branch October 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants