Abort if category is not a child of the root category #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieliMi
commented
Dec 15, 2020
| protected function isChildOfRootCategory($category) | ||
| { | ||
| // split the path into its segments | ||
| $categoryPathParts = explode('/', $category[MemberNames::PATH]); |
There was a problem hiding this comment.
If a category is not yet present but created on the fly by pacemaker $category[MemberNames::PATH]) is empty and the method will return false.
There was a problem hiding this comment.
We somehow have to catch this case and find a different solution.
There was a problem hiding this comment.
@DanieliMi Sorry, but I think I can't really follow you here. When Pacemaker will create a category on-the-fly, this will happen before this observer will be invoked. Can you please describe in more details how this case can come about?
There was a problem hiding this comment.
I will improve the Steps to reproduce
There was a problem hiding this comment.
isn't this similar to techdivision/import#209 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Importing a simple product into two websites with different category roots will cause an error, this is because it will try to generate a url rewrite for the root category of the other store since it's not recognized as one (it's trying to access url path but root categories do not have one). This PR fixes this issue.
Steps to reproduce
Expected result
The product is imported into each category with according url rewrites.
Actual result
The import fails due to missing url path of the one root category.