Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New joomla user search API #66

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

samadhansalunkhe
Copy link

Referenced Issue - https://github.com/ekstep/Community-Portal-Joomla/issues/5197

  • Have you done PHPCS?

@@ -0,0 +1,46 @@
<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolbung should resource name be search?

Copy link
Contributor

@thite-amol thite-amol Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think search API is nothing but the list view with the additional filters. Can we merge this code with users post API? cc @coolbung

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Please go ahead as discussed.

Once merged, moved out the plugins in the respective repos. Any plugin that does not have a specific repo can stay here.

@@ -0,0 +1,46 @@
<?php
/**
* @package Joomla.Administrator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samadhansalunkhe change copyright, year etc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants